chrome/test/data/predictors/subresource_fcp_order.html - Issue 2755093002: predictors: Mark before_first_contentful_paint for resources fetched before fcp.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/predictors/subresource_fcp_order.html

Issue 2755093002: predictors: Mark before_first_contentful_paint for resources fetched before fcp. (Closed)

Patch Set: before_first_contentful_paint browser_test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Subresources collection</title>

	5 <link rel="stylesheet" href="/handled-by-test/style.css">

	6 <script src="/handled-by-test/script.js"></script>

	7 </head>

	8 <body>

	9 <p>Hello world!</p>

	10 <script>

	11 document.body.style.backgroundColor = 'red';
	alexilin 2017/04/21 13:49:05 Why do you need to change backgroundColor? Doesn't Why do you need to change backgroundColor? Doesn't fcp happen without it? trevordixon 2017/04/25 12:46:10 Doesn't appear to be necessary. Deleted. Show quoted text On 2017/04/21 at 13:49:05, alexilin wrote: > Why do you need to change backgroundColor? Doesn't fcp happen without it? Doesn't appear to be necessary. Deleted.
	12 // Using document.write would allow the preload scanner to pick up this

	13 // resource and throw off results.

	14 document.body.insertAdjacentHTML('beforeend', `<img src="google.png">`);

	15 </script>

	16 <script src="/handled-by-test/long-script.js"></script>

	17 </body>

	18 </html>

OLD	NEW