Ignore accessibility events fired on objects that aren't in the tree.

Ignore accessibility events fired on objects that aren't in the tree.

BUG=371039
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271251

[Peter Lundblad, 2014-05-07 23:03:23]

lgtm

https://codereview.chromium.org/275503002/diff/1/content/renderer/accessibili...
File content/renderer/accessibility/renderer_accessibility_browsertest.cc
(right):

https://codereview.chromium.org/275503002/diff/1/content/renderer/accessibili...
content/renderer/accessibility/renderer_accessibility_browsertest.cc:520: //
Test RendererAccessibilityComplete and make sure it doesn't sent anything
nit: s/sent/send/

https://codereview.chromium.org/275503002/diff/1/content/renderer/accessibili...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/275503002/diff/1/content/renderer/accessibili...
content/renderer/accessibility/renderer_accessibility_complete.cc:189: if
(!tree_source_.IsInTree(obj))
Can you add some brief comment why the node wouldn't be in the tree?

[dmazzoni, 2014-05-08 15:12:23]

https://codereview.chromium.org/275503002/diff/1/content/renderer/accessibili...
File content/renderer/accessibility/renderer_accessibility_browsertest.cc
(right):

https://codereview.chromium.org/275503002/diff/1/content/renderer/accessibili...
content/renderer/accessibility/renderer_accessibility_browsertest.cc:520: //
Test RendererAccessibilityComplete and make sure it doesn't sent anything
On 2014/05/07 23:03:24, Peter Lundblad wrote:
> nit: s/sent/send/

Done.

https://codereview.chromium.org/275503002/diff/1/content/renderer/accessibili...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/275503002/diff/1/content/renderer/accessibili...
content/renderer/accessibility/renderer_accessibility_complete.cc:189: if
(!tree_source_.IsInTree(obj))
On 2014/05/07 23:03:24, Peter Lundblad wrote:
> Can you add some brief comment why the node wouldn't be in the tree?

Done.

[dmazzoni, 2014-05-09 06:23:57]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-05-09 06:29:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/275503002/10001

[commit-bot: I haz the power, 2014-05-09 08:19:56]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-09 09:47:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 09:47:40]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[dmazzoni, 2014-05-16 21:30:05]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-05-16 23:32:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/275503002/30001

[commit-bot: I haz the power, 2014-05-17 18:05:35]

Change committed as 271251