Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2755023002: Guard analysis server's getAnalysisResult, must be dart (Closed)

Created:
3 years, 9 months ago by mfairhurst
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Guard analysis server's getAnalysisResult, must be dart Otherwise spews errors inside html files when users do things like autocomplete in the middle of them. BUG= R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/319b726f8b18451bd02645e1cc3bf8e5713780f2

Patch Set 1 #

Patch Set 2 : Guard analysis server's getAnalysisResult, must be dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mfairhurst
3 years, 9 months ago (2017-03-16 22:57:27 UTC) #2
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-16 23:53:31 UTC) #3
scheglov
LGTM
3 years, 9 months ago (2017-03-17 06:16:15 UTC) #4
mfairhurst
3 years, 9 months ago (2017-03-17 17:42:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
319b726f8b18451bd02645e1cc3bf8e5713780f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698