third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h - Issue 2755013004: Improve how DocumentMarkerController updates markers in response to text edits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2755013004: Improve how DocumentMarkerController updates markers in response to text edits (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

index 33aca40ed2798e694753f511137957e5e2fd0a79..398d743267b66a45f2ff01ec3d3850272d81f20d 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

@@ -30,6 +30,7 @@

#define DocumentMarkerController_h

#include "core/CoreExport.h"

+#include "core/dom/SynchronousMutationObserver.h"

#include "core/editing/iterators/TextIterator.h"

#include "core/editing/markers/DocumentMarker.h"

#include "platform/geometry/IntRect.h"

@@ -103,7 +104,6 @@ class CORE_EXPORT DocumentMarkerController final

void RemoveMarkers(const MarkerRemoverPredicate& should_remove_marker);

void RepaintMarkers(

DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());

- void ShiftMarkers(Node*, unsigned start_offset, int delta);

// Returns true if markers within a range are found.

bool SetMarkersActive(const EphemeralRange&, bool);

// Returns true if markers within a range defined by a node, |startOffset| and