third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp - Issue 2755013004: Improve how DocumentMarkerController updates markers in response to text edits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

Issue 2755013004: Improve how DocumentMarkerController updates markers in response to text edits (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

index b39fbc6b50efe77cecce316f747bff5731276796..e2345c607a1baddb136af3d77fd52b3c48f92975 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

@@ -471,9 +471,9 @@ void InsertParagraphSeparatorCommand::DoApply(EditingState* editing_state) {

DCHECK(!text_node->GetLayoutObject() ||

text_node->GetLayoutObject()->Style()->CollapseWhiteSpace())

<< text_node;

- ReplaceTextInNodePreservingMarkers(

- text_node, leading_whitespace.ComputeOffsetInContainerNode(), 1,

- NonBreakingSpaceString());

+ ReplaceTextInNode(text_node,

+ leading_whitespace.ComputeOffsetInContainerNode(), 1,

+ NonBreakingSpaceString());

GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();

}