third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h - Issue 2755013004: Improve how DocumentMarkerController updates markers in response to text edits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2755013004: Improve how DocumentMarkerController updates markers in response to text edits (Closed)

Patch Set: Rebase (Vector::remove() => Vector::erase()) Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

index d759b830964c19c5772b67eb272b1d8a3637541b..7d56b8a499759acaa533cd738a4fb483e50e3220 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

@@ -30,6 +30,7 @@

#define DocumentMarkerController_h

#include "core/CoreExport.h"

+#include "core/dom/SynchronousMutationObserver.h"

#include "core/editing/iterators/TextIterator.h"

#include "core/editing/markers/DocumentMarker.h"

#include "platform/geometry/IntRect.h"

@@ -107,7 +108,6 @@ class CORE_EXPORT DocumentMarkerController final

void removeMarkers(const MarkerRemoverPredicate& shouldRemoveMarker);

void repaintMarkers(

DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());

- void shiftMarkers(Node*, unsigned startOffset, int delta);

// Returns true if markers within a range are found.

bool setMarkersActive(const EphemeralRange&, bool);

// Returns true if markers within a range defined by a node, |startOffset| and

@@ -147,6 +147,10 @@ class CORE_EXPORT DocumentMarkerController final

using MarkerMap = HeapHashMap<WeakMember<const Node>, Member<MarkerLists>>;

void mergeOverlapping(MarkerList*, RenderedDocumentMarker*);

bool possiblyHasMarkers(DocumentMarker::MarkerTypes);

+ bool relocateMarkerIfNeeded(RenderedDocumentMarker*,

+ unsigned offset,

+ unsigned oldLength,

+ unsigned newLength);

void removeMarkersFromList(MarkerMap::iterator, DocumentMarker::MarkerTypes);

void removeMarkers(TextIterator&,

DocumentMarker::MarkerTypes,