third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h - Issue 2755013004: Improve how DocumentMarkerController updates markers in response to text edits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

Issue 2755013004: Improve how DocumentMarkerController updates markers in response to text edits (Closed)

Patch Set: Rebase (Vector::remove() => Vector::erase()) Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp ('K') | « third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

index d4d1f9b32f00e9fa744e3127bc251ca94a08c672..471e187d4a7ca5a6c4927b8fc233d85365fd9628 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

@@ -156,10 +156,6 @@ class CORE_EXPORT CompositeEditCommand : public EditCommand {

unsigned count,

const String& replacementText);

Position replaceSelectedTextInNode(const String&);

- void replaceTextInNodePreservingMarkers(Text*,

- unsigned offset,

- unsigned count,

- const String& replacementText);

Position positionOutsideTabSpan(const Position&);

void setNodeAttribute(Element*,

const QualifiedName& attribute,