Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerTest.cpp

Issue 2755013004: Improve how DocumentMarkerController updates markers in response to text edits (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/editing/markers/DocumentMarker.h" 5 #include "core/editing/markers/DocumentMarker.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
11 class DocumentMarkerTest : public ::testing::Test {}; 11 using MarkerOffsets = DocumentMarker::MarkerOffsets;
12
13 class DocumentMarkerTest : public ::testing::Test {
14 protected:
15 DocumentMarker* CreateMarker(unsigned startOffset, unsigned endOffset) {
16 return new DocumentMarker(startOffset, endOffset,
17 DocumentMarker::MatchStatus::kInactive);
18 }
19 };
12 20
13 TEST_F(DocumentMarkerTest, MarkerTypeIteratorEmpty) { 21 TEST_F(DocumentMarkerTest, MarkerTypeIteratorEmpty) {
14 DocumentMarker::MarkerTypes types(0); 22 DocumentMarker::MarkerTypes types(0);
15 EXPECT_TRUE(types.begin() == types.end()); 23 EXPECT_TRUE(types.begin() == types.end());
16 } 24 }
17 25
18 TEST_F(DocumentMarkerTest, MarkerTypeIteratorOne) { 26 TEST_F(DocumentMarkerTest, MarkerTypeIteratorOne) {
19 DocumentMarker::MarkerTypes types(DocumentMarker::kSpelling); 27 DocumentMarker::MarkerTypes types(DocumentMarker::kSpelling);
20 ASSERT_TRUE(types.begin() != types.end()); 28 ASSERT_TRUE(types.begin() != types.end());
21 auto it = types.begin(); 29 auto it = types.begin();
(...skipping 16 matching lines...) Expand all
38 TEST_F(DocumentMarkerTest, MarkerTypeIteratorDistributed) { 46 TEST_F(DocumentMarkerTest, MarkerTypeIteratorDistributed) {
39 DocumentMarker::MarkerTypes types(0b101); // Spelling | TextMatch 47 DocumentMarker::MarkerTypes types(0b101); // Spelling | TextMatch
40 ASSERT_TRUE(types.begin() != types.end()); 48 ASSERT_TRUE(types.begin() != types.end());
41 auto it = types.begin(); 49 auto it = types.begin();
42 EXPECT_EQ(DocumentMarker::kSpelling, *it); 50 EXPECT_EQ(DocumentMarker::kSpelling, *it);
43 ++it; 51 ++it;
44 EXPECT_EQ(DocumentMarker::kTextMatch, *it); 52 EXPECT_EQ(DocumentMarker::kTextMatch, *it);
45 ++it; 53 ++it;
46 EXPECT_TRUE(it == types.end()); 54 EXPECT_TRUE(it == types.end());
47 } 55 }
56
57 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_DeleteAfter) {
58 DocumentMarker* marker = CreateMarker(0, 5);
59 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 0);
60 EXPECT_EQ(0u, result.value().start_offset);
61 EXPECT_EQ(5u, result.value().end_offset);
48 } 62 }
63
64 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_DeleteEndAndAfter) {
65 DocumentMarker* marker = CreateMarker(10, 15);
66 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 0);
67 EXPECT_EQ(10u, result.value().start_offset);
68 EXPECT_EQ(13u, result.value().end_offset);
69 }
70
71 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_DeleteBeforeAndAfter) {
72 DocumentMarker* marker = CreateMarker(20, 25);
73 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 0);
74 EXPECT_EQ(WTF::kNullopt, result);
75 }
76
77 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_DeleteBeforeAndBeginning) {
78 DocumentMarker* marker = CreateMarker(30, 35);
79 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 0);
80 EXPECT_EQ(13u, result.value().start_offset);
81 EXPECT_EQ(16u, result.value().end_offset);
82 }
83
84 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_DeleteBefore) {
85 DocumentMarker* marker = CreateMarker(40, 45);
86 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 0);
87 EXPECT_EQ(21u, result.value().start_offset);
88 EXPECT_EQ(26u, result.value().end_offset);
89 }
90
91 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_DeleteStartAndAfter) {
92 DocumentMarker* marker = CreateMarker(0, 5);
93 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(0, 10, 0);
94 EXPECT_EQ(WTF::kNullopt, result);
95 }
96
97 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_DeleteBeforeAndEnd) {
98 DocumentMarker* marker = CreateMarker(5, 10);
99 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(0, 10, 0);
100 EXPECT_EQ(WTF::kNullopt, result);
101 }
102
103 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_DeleteMarkerExactly) {
104 DocumentMarker* marker = CreateMarker(5, 10);
105 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(5, 5, 0);
106 EXPECT_EQ(WTF::kNullopt, result);
107 }
108
109 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_DeleteMiddleOfMarker) {
110 DocumentMarker* marker = CreateMarker(5, 10);
111 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(6, 3, 0);
112 EXPECT_EQ(5u, result.value().start_offset);
113 EXPECT_EQ(7u, result.value().end_offset);
114 }
115
116 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_InsertAfter) {
117 DocumentMarker* marker = CreateMarker(0, 5);
118 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(10, 0, 5);
119 EXPECT_EQ(0u, result.value().start_offset);
120 EXPECT_EQ(5u, result.value().end_offset);
121 }
122
123 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_InsertImmediatelyAfter) {
124 DocumentMarker* marker = CreateMarker(0, 5);
125 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(5, 0, 5);
126 EXPECT_EQ(0u, result.value().start_offset);
127 EXPECT_EQ(5u, result.value().end_offset);
128 }
129
130 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_InsertInMiddle) {
131 DocumentMarker* marker = CreateMarker(0, 5);
132 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(2, 0, 5);
133 EXPECT_EQ(0u, result.value().start_offset);
134 EXPECT_EQ(10u, result.value().end_offset);
135 }
136
137 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_InsertImmediatelyBefore) {
138 DocumentMarker* marker = CreateMarker(0, 5);
139 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(0, 0, 5);
140 EXPECT_EQ(5u, result.value().start_offset);
141 EXPECT_EQ(10u, result.value().end_offset);
142 }
143
144 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_InsertBefore) {
145 DocumentMarker* marker = CreateMarker(5, 10);
146 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(0, 0, 5);
147 EXPECT_EQ(10u, result.value().start_offset);
148 EXPECT_EQ(15u, result.value().end_offset);
149 }
150
151 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceAfter) {
152 DocumentMarker* marker = CreateMarker(0, 5);
153 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 1);
154 EXPECT_EQ(0u, result.value().start_offset);
155 EXPECT_EQ(5u, result.value().end_offset);
156 }
157
158 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceEndAndAfter) {
159 DocumentMarker* marker = CreateMarker(10, 15);
160 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 1);
161 EXPECT_EQ(10u, result.value().start_offset);
162 EXPECT_EQ(13u, result.value().end_offset);
163 }
164
165 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceBeforeAndAfter) {
166 DocumentMarker* marker = CreateMarker(20, 25);
167 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 1);
168 EXPECT_EQ(WTF::kNullopt, result);
169 }
170
171 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceBeforeAndBeginning) {
172 DocumentMarker* marker = CreateMarker(30, 35);
173 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 1);
174 EXPECT_EQ(14u, result.value().start_offset);
175 EXPECT_EQ(17u, result.value().end_offset);
176 }
177
178 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceBefore) {
179 DocumentMarker* marker = CreateMarker(40, 45);
180 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(13, 19, 1);
181 EXPECT_EQ(22u, result.value().start_offset);
182 EXPECT_EQ(27u, result.value().end_offset);
183 }
184
185 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceBeginning) {
186 DocumentMarker* marker = CreateMarker(0, 5);
187 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(0, 2, 1);
188 EXPECT_EQ(0u, result.value().start_offset);
189 EXPECT_EQ(4u, result.value().end_offset);
190 }
191
192 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceEnd) {
193 DocumentMarker* marker = CreateMarker(0, 5);
194 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(3, 2, 1);
195 EXPECT_EQ(0u, result.value().start_offset);
196 EXPECT_EQ(4u, result.value().end_offset);
197 }
198
199 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceExactly) {
200 DocumentMarker* marker = CreateMarker(0, 5);
201 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(0, 5, 1);
202 EXPECT_EQ(0u, result.value().start_offset);
203 EXPECT_EQ(1u, result.value().end_offset);
204 }
205
206 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceBeginningAndAfter) {
207 DocumentMarker* marker = CreateMarker(0, 5);
208 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(0, 6, 1);
209 EXPECT_EQ(WTF::kNullopt, result);
210 }
211
212 TEST_F(DocumentMarkerTest, GetShiftedMarkerPosition_ReplaceBeforeAndEnd) {
213 DocumentMarker* marker = CreateMarker(5, 10);
214 Optional<MarkerOffsets> result = marker->ComputeOffsetsAfterShift(4, 6, 1);
215 EXPECT_EQ(WTF::kNullopt, result);
216 }
217
218 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698