Improve how DocumentMarkerController updates markers in response to text edits

third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 157 matching lines @@
       details_(TextCompositionMarkerDetails::Create(underline_color,
                                                     thick,
                                                     background_color)) {}
 
 DocumentMarker::DocumentMarker(const DocumentMarker& marker)
     : type_(marker.GetType()),
       start_offset_(marker.StartOffset()),
       end_offset_(marker.EndOffset()),
       details_(marker.Details()) {}
 
+Optional<DocumentMarker::MarkerOffsets>
+DocumentMarker::ComputeOffsetsAfterShift(unsigned offset,
+                                         unsigned old_length,
+                                         unsigned new_length) const {
+  MarkerOffsets result;
+  result.start_offset = StartOffset();
+  result.end_offset = EndOffset();
+
+  // algorithm inspired by https://dom.spec.whatwg.org/#concept-cd-replace
+  // but with some changes
+
+  // Deviation from the concept-cd-replace algorithm: second condition in the
+  // next line (don't include text inserted immediately before a marker in the
+  // marked range, but do include the new text if it's replacing text in the
+  // marked range)
+  if (StartOffset() > offset || (StartOffset() == offset && old_length == 0)) {
+    if (StartOffset() <= offset + old_length) {
+      // Marker start was in the replaced text. Move to end of new text
+      // (Deviation from the concept-cd-replace algorithm: that algorithm
+      // would move to the beginning of the new text here)
+      result.start_offset = offset + new_length;
+    } else {
+      // Marker start was after the replaced text. Shift by length
+      // difference
+      result.start_offset = StartOffset() + new_length - old_length;
+    }
+  }
+
+  if (EndOffset() > offset) {
+    // Deviation from the concept-cd-replace algorithm: < instead of <= in
+    // the next line
+    if (EndOffset() < offset + old_length) {
+      // Marker end was in the replaced text. Move to beginning of new text
+      result.end_offset = offset;
+    } else {
+      // Marker end was after the replaced text. Shift by length difference
+      result.end_offset = EndOffset() + new_length - old_length;
+    }
+  }
+
+  if (result.start_offset >= result.end_offset)
+    return WTF::kNullopt;
+
+  return result;
+}
+
 void DocumentMarker::ShiftOffsets(int delta) {
   start_offset_ += delta;
   end_offset_ += delta;
 }
 
 void DocumentMarker::SetIsActiveMatch(bool active) {
   details_ = DocumentMarkerTextMatch::Create(
       active ? DocumentMarker::MatchStatus::kActive
              : DocumentMarker::MatchStatus::kInactive);
 }
@@ skipping 31 matching lines @@
           ToTextCompositionMarkerDetails(details_.Get()))
     return details->BackgroundColor();
   return Color::kTransparent;
 }
 
 DEFINE_TRACE(DocumentMarker) {
   visitor->Trace(details_);
 }
 
 }  // namespace blink