Improve how DocumentMarkerController updates markers in response to text edits

third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/editing/commands/CompositeEditCommand.h"
 
+#include <algorithm>
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/HTMLNames.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentFragment.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/Range.h"
 #include "core/dom/Text.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/Editor.h"
 #include "core/editing/PlainTextRange.h"
 #include "core/editing/RelocatablePosition.h"
 #include "core/editing/VisibleUnits.h"
 #include "core/editing/commands/AppendNodeCommand.h"
 #include "core/editing/commands/ApplyStyleCommand.h"
 #include "core/editing/commands/DeleteFromTextNodeCommand.h"
 #include "core/editing/commands/DeleteSelectionCommand.h"
 #include "core/editing/commands/InsertIntoTextNodeCommand.h"
 #include "core/editing/commands/InsertLineBreakCommand.h"
 #include "core/editing/commands/InsertNodeBeforeCommand.h"
 #include "core/editing/commands/InsertParagraphSeparatorCommand.h"
 #include "core/editing/commands/MergeIdenticalElementsCommand.h"
 #include "core/editing/commands/RemoveCSSPropertyCommand.h"
 #include "core/editing/commands/RemoveNodeCommand.h"
 #include "core/editing/commands/RemoveNodePreservingChildrenCommand.h"
 #include "core/editing/commands/ReplaceNodeWithSpanCommand.h"
 #include "core/editing/commands/ReplaceSelectionCommand.h"
+#include "core/editing/commands/SetCharacterDataCommand.h"
 #include "core/editing/commands/SetNodeAttributeCommand.h"
 #include "core/editing/commands/SplitElementCommand.h"
 #include "core/editing/commands/SplitTextNodeCommand.h"
 #include "core/editing/commands/SplitTextNodeContainingElementCommand.h"
 #include "core/editing/commands/WrapContentsInDummySpanCommand.h"
 #include "core/editing/iterators/TextIterator.h"
 #include "core/editing/markers/DocumentMarkerController.h"
 #include "core/editing/serializers/Serialization.h"
 #include "core/editing/spellcheck/SpellChecker.h"
 #include "core/events/ScopedEventQueue.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLBRElement.h"
 #include "core/html/HTMLDivElement.h"
 #include "core/html/HTMLElement.h"
 #include "core/html/HTMLLIElement.h"
 #include "core/html/HTMLQuoteElement.h"
 #include "core/html/HTMLSpanElement.h"
 #include "core/layout/LayoutBlock.h"
 #include "core/layout/LayoutListItem.h"
 #include "core/layout/LayoutText.h"
 #include "core/layout/line/InlineTextBox.h"
-#include <algorithm>
 
 namespace blink {
 
 using namespace HTMLNames;
 
 CompositeEditCommand::CompositeEditCommand(Document& document)
     : EditCommand(document) {
   SetStartingSelection(document.GetFrame()
                            ->Selection()
                            .ComputeVisibleSelectionInDOMTreeDeprecated());
@@ skipping 446 matching lines @@
   // DeleteFromTextNodeCommand is never aborted.
   ApplyCommandToComposite(
       DeleteFromTextNodeCommand::Create(node, offset, count),
       ASSERT_NO_EDITING_ABORT);
 }
 
 void CompositeEditCommand::ReplaceTextInNode(Text* node,
                                              unsigned offset,
                                              unsigned count,
                                              const String& replacement_text) {
-  // DeleteFromTextNodeCommand and InsertIntoTextNodeCommand are never
-  // aborted.
+  // SetCharacterDataCommand is never aborted.
   ApplyCommandToComposite(
-      DeleteFromTextNodeCommand::Create(node, offset, count),
+      SetCharacterDataCommand::Create(node, offset, count, replacement_text),
       ASSERT_NO_EDITING_ABORT);
-  if (!replacement_text.IsEmpty())
-    ApplyCommandToComposite(
-        InsertIntoTextNodeCommand::Create(node, offset, replacement_text),
-        ASSERT_NO_EDITING_ABORT);
 }
 
 Position CompositeEditCommand::ReplaceSelectedTextInNode(const String& text) {
   Position start = EndingSelection().Start();
   Position end = EndingSelection().end();
   if (start.ComputeContainerNode() != end.ComputeContainerNode() ||
       !start.ComputeContainerNode()->IsTextNode() ||
       IsTabHTMLSpanElementTextNode(start.ComputeContainerNode()))
     return Position();
 
   Text* text_node = ToText(start.ComputeContainerNode());
   ReplaceTextInNode(text_node, start.OffsetInContainerNode(),
                     end.OffsetInContainerNode() - start.OffsetInContainerNode(),
                     text);
 
   return Position(text_node, start.OffsetInContainerNode() + text.length());
 }
 
-static void CopyMarkerTypesAndDescriptions(
-    const DocumentMarkerVector& marker_pointers,
-    Vector<DocumentMarker::MarkerType>& types,
-    Vector<String>& descriptions) {
-  size_t array_size = marker_pointers.size();
-  types.ReserveCapacity(array_size);
-  descriptions.ReserveCapacity(array_size);
-  for (const auto& marker_pointer : marker_pointers) {
-    types.push_back(marker_pointer->GetType());
-    descriptions.push_back(marker_pointer->Description());
-  }
-}
-
-void CompositeEditCommand::ReplaceTextInNodePreservingMarkers(
-    Text* node,
-    unsigned offset,
-    unsigned count,
-    const String& replacement_text) {
-  DocumentMarkerController& marker_controller = GetDocument().Markers();
-  Vector<DocumentMarker::MarkerType> types;
-  Vector<String> descriptions;
-  CopyMarkerTypesAndDescriptions(
-      marker_controller.MarkersInRange(
-          EphemeralRange(Position(node, offset),
-                         Position(node, offset + count)),
-          DocumentMarker::AllMarkers()),
-      types, descriptions);
-
-  ReplaceTextInNode(node, offset, count, replacement_text);
-
-  // Re-adding markers requires a clean tree.
-  GetDocument().UpdateStyleAndLayout();
-
-  DocumentLifecycle::DisallowTransitionScope disallow_transition(
-      GetDocument().Lifecycle());
-  Position start_position(node, offset);
-  Position end_position(node, offset + replacement_text.length());
-  DCHECK_EQ(types.size(), descriptions.size());
-
-  for (size_t i = 0; i < types.size(); ++i)
-    marker_controller.AddMarker(start_position, end_position, types[i],
-                                descriptions[i]);
-}
-
 Position CompositeEditCommand::PositionOutsideTabSpan(const Position& pos) {
   if (!IsTabHTMLSpanElementTextNode(pos.AnchorNode()))
     return pos;
 
   switch (pos.AnchorType()) {
     case PositionAnchorType::kBeforeChildren:
     case PositionAnchorType::kAfterChildren:
       NOTREACHED();
       return pos;
     case PositionAnchorType::kOffsetInAnchor:
@@ skipping 144 matching lines @@
       !IsWhitespace(ToText(text_node->nextSibling())->data()[0]);
   const bool should_emit_nbs_pbefore_end =
       (IsEndOfParagraph(visible_downstream_pos) ||
        (unsigned)downstream == text.length()) &&
       !next_sibling_is_text_node;
   String rebalanced_string = StringWithRebalancedWhitespace(
       string, IsStartOfParagraph(visible_upstream_pos) || !upstream,
       should_emit_nbs_pbefore_end);
 
   if (string != rebalanced_string)
-    ReplaceTextInNodePreservingMarkers(text_node, upstream, length,
-                                       rebalanced_string);
+    ReplaceTextInNode(text_node, upstream, length, rebalanced_string);
 }
 
 void CompositeEditCommand::PrepareWhitespaceAtPositionForSplit(
     Position& position) {
   if (!IsRichlyEditablePosition(position))
     return;
   Node* node = position.AnchorNode();
   if (!node || !node->IsTextNode())
     return;
   Text* text_node = ToText(node);
@@ skipping 21 matching lines @@
 }
 
 void CompositeEditCommand::
     ReplaceCollapsibleWhitespaceWithNonBreakingSpaceIfNeeded(
         const VisiblePosition& visible_position) {
   if (!IsCollapsibleWhitespace(CharacterAfter(visible_position)))
     return;
   Position pos = MostForwardCaretPosition(visible_position.DeepEquivalent());
   if (!pos.ComputeContainerNode() || !pos.ComputeContainerNode()->IsTextNode())
     return;
-  ReplaceTextInNodePreservingMarkers(ToText(pos.ComputeContainerNode()),
-                                     pos.OffsetInContainerNode(), 1,
-                                     NonBreakingSpaceString());
+  ReplaceTextInNode(ToText(pos.ComputeContainerNode()),
+                    pos.OffsetInContainerNode(), 1, NonBreakingSpaceString());
 }
 
 void CompositeEditCommand::RebalanceWhitespace() {
   VisibleSelection selection = EndingSelection();
   if (selection.IsNone())
     return;
 
   RebalanceWhitespaceAt(selection.Start());
   if (selection.IsRange())
     RebalanceWhitespaceAt(selection.end());
@@ skipping 1188 matching lines @@
 
 DEFINE_TRACE(CompositeEditCommand) {
   visitor->Trace(commands_);
   visitor->Trace(starting_selection_);
   visitor->Trace(ending_selection_);
   visitor->Trace(undo_step_);
   EditCommand::Trace(visitor);
 }
 
 }  // namespace blink