Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

Issue 2755003003: Add Interstitial for user consent (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java
index d18e18f141f948abd9d86ee90db7668874a25719..5274db171bcf1ab5f133db1537ba94b9f9cfcff1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java
@@ -84,7 +84,7 @@ public class PhysicalWebBroadcastService extends Service {
IntentFilter filter = new IntentFilter(STOP_SERVICE);
registerReceiver(mBroadcastReceiver, filter);
- // TODO(iankc): implement parsing, broadcasting, Url Shortener.
+ // TODO(iankc): implement broadcasting, Url Shortener.
createBroadcastNotification(displayUrl);
return START_STICKY;
}
@@ -150,4 +150,6 @@ public class PhysicalWebBroadcastService extends Service {
(NotificationManager) getSystemService(NOTIFICATION_SERVICE));
notificationManager.cancel(NotificationConstants.NOTIFICATION_ID_PHYSICAL_WEB);
}
+
+ private native byte[] nativeEncodeUrl(String url);
cco3 2017/03/16 22:54:32 This doesn't belong in this change, right?
iankc 2017/03/17 00:08:44 Done.
}

Powered by Google App Engine
This is Rietveld 408576698