Add Interstitial for user consent

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 85 matching lines @@
 import org.chromium.chrome.browser.nfc.BeamController;
 import org.chromium.chrome.browser.nfc.BeamProvider;
 import org.chromium.chrome.browser.ntp.NewTabPage;
 import org.chromium.chrome.browser.ntp.NewTabPageUma;
 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
 import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
 import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;
 import org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup;
 import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations;
 import org.chromium.chrome.browser.physicalweb.PhysicalWebShareActivity;
+import org.chromium.chrome.browser.physicalweb.PhysicalWebShareEntryActivity;
 import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
 import org.chromium.chrome.browser.preferences.PrefServiceBridge;
 import org.chromium.chrome.browser.preferences.PreferencesLauncher;
 import org.chromium.chrome.browser.printing.PrintShareActivity;
 import org.chromium.chrome.browser.printing.TabPrinter;
 import org.chromium.chrome.browser.share.OptionalShareTargetsManager;
 import org.chromium.chrome.browser.share.ShareActivity;
 import org.chromium.chrome.browser.share.ShareHelper;
 import org.chromium.chrome.browser.snackbar.BottomContainer;
 import org.chromium.chrome.browser.snackbar.DataReductionPromoSnackbarController;
@@ skipping 1714 matching lines @@
             onShareMenuItemSelected(id == R.id.direct_share_menu_id,
                     getCurrentTabModel().isIncognito());
         } else if (id == R.id.print_id) {
             PrintingController printingController = PrintingControllerImpl.getInstance();
             if (printingController != null && !printingController.isBusy()
                     && PrefServiceBridge.getInstance().isPrintingEnabled()) {
                 printingController.startPrint(new TabPrinter(currentTab),
                         new PrintManagerDelegateImpl(this));
                 RecordUserAction.record("MobileMenuPrint");
             }
+        } else if (id == R.id.physical_web_sharing_id) {
+            Intent intent = new Intent(this, PhysicalWebShareEntryActivity.class);

[Ted C, 2017/03/20 21:05:59]

I saw the commit message, but I'm not sure I follow why this can't be in
PhysicalWebShareActivity?

You have access to triggeringActivity, so you should be able to do
triggeringActivity.getActivityTab().getUrl() and have access to the same.

[iankc, 2017/03/20 21:32:22]

The problem isn't gaining access to the URL.
The problem is that the existence of the PhysicalWebShareActivity is dependent
on the activity state, as seen in the OptionalShareTargetsManager.java. So when
the PhysicalWebShareActivity goes into a different state, caused by launching an
alert dialog, then the application will crash. More simply: alert dialog tries
to go up, activity state changes, PhysicalWebShareActivity disabled and
destroyed, application crashes because alert dialog has lost its launching
activity.
So the solution is to tell the ChromeActivity to launch a new activity
(PhysicalWebShareENTRYActivity) that has a transparent layout to display the
alert dialog.

[Ted C, 2017/03/21 00:01:22]

I guess I'm surprised as the manager only unregisters when they get something
other than PAUSE.  You shouldn't be getting STOP for the underlying activity
when showing a dialog as it is still visible.

If you add logs in onActivityStateChange in the manager, what are you seeing
as the sequence for your activity types?

[iankc, 2017/03/21 01:19:52]

When
0. Click Share on menu.
1. Log: Components Enabled.
2. Click PhysicalWebLogo on Sharesheet.
3. Log: PhysicalWebShareActivity Started.
3.5 Here is where it starts to fire the dialog.
4. Log: Disabling components.
5. WindowManager Error: android.view.WindowLeaked: Activity
org.chromium.chrome.browser.physicalweb.PhysicalWebShareActivity has leaked
window com.android.internal.policy.PhoneWindow$DecorView{2ed1c93 V.E......
R......D 0,0-1280,829} that was originally added here

+            intent.putExtra(PhysicalWebShareEntryActivity.SHARING_ENTRY_URL, currentTab.getUrl());
+            startActivity(intent);
         } else if (id == R.id.add_to_homescreen_id) {
             AddToHomescreenManager addToHomescreenManager =
                     new AddToHomescreenManager(this, currentTab);
             addToHomescreenManager.start();
             RecordUserAction.record("MobileMenuAddToHomescreen");
         } else if (id == R.id.open_webapk_id) {
             Context context = ContextUtils.getApplicationContext();
             String packageName = WebApkValidator.queryWebApkPackage(context, currentTab.getUrl());
             Intent launchIntent =
                     context.getPackageManager().getLaunchIntentForPackage(packageName);
@@ skipping 267 matching lines @@
      * draw over VR contents should be hidden in this call.
      */
     public void onEnterVR() {}
 
     /**
      * Called when VR mode using this activity is exited. Any state set for VR should be restored
      * in this call, including showing 2D UI that was hidden.
      */
     public void onExitVR() {}
 }