third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp - Issue 2754983002: Composite sticky-positioned elements when they have composited descendants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 2754983002: Composite sticky-positioned elements when they have composited descendants (Closed)

Patch Set: Address pdr comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 ('K') | « third_party/WebKit/LayoutTests/compositing/overflow/mixed-composited-nested-sticky-overflow-scroller-expected.html ('k') | third_party/WebKit/Source/platform/graphics/CompositingReasons.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

index 54502ea395576daf2d6d81f50626119604972e21..43d57ebe4b042d11783e96ac70281c34fc84ca55 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

@@ -195,11 +195,10 @@ static CompositingReasons SubtreeReasonsForCompositing(

// scroll-dependant fixed position elements with composited descendants for

// correctness - even if we lose LCD.

const bool ignore_lcd_text = true;

- if (layer->GetLayoutObject().Style()->GetPosition() == EPosition::kFixed &&

- compositing_reason_finder.RequiresCompositingForScrollDependentPosition(

+ if (compositing_reason_finder.RequiresCompositingForScrollDependentPosition(

layer, ignore_lcd_text)) {

subtree_reasons |=

- kCompositingReasonPositionFixedWithCompositedDescendants;

+ kCompositingReasonPositionFixedOrStickyWithCompositedDescendants;

}