Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/CompositingReasons.cpp

Issue 2754983002: Composite sticky-positioned elements when they have composited descendants (Closed)
Patch Set: Address chrishtr comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/CompositingReasons.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/CompositingReasons.h" 5 #include "platform/graphics/CompositingReasons.h"
6 6
7 #include "platform/wtf/StdLibExtras.h" 7 #include "platform/wtf/StdLibExtras.h"
8 #include "platform/wtf/text/StringBuilder.h" 8 #include "platform/wtf/text/StringBuilder.h"
9 9
10 namespace blink { 10 namespace blink {
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 "of 3d descendants"}, 81 "of 3d descendants"},
82 {kCompositingReasonPreserve3DWith3DDescendants, 82 {kCompositingReasonPreserve3DWith3DDescendants,
83 "preserve3DWith3DDescendants", 83 "preserve3DWith3DDescendants",
84 "Has a preserves-3d property that needs to be known by compositor because " 84 "Has a preserves-3d property that needs to be known by compositor because "
85 "of 3d descendants"}, 85 "of 3d descendants"},
86 {kCompositingReasonReflectionOfCompositedParent, 86 {kCompositingReasonReflectionOfCompositedParent,
87 "reflectionOfCompositedParent", "Is a reflection of a composited layer"}, 87 "reflectionOfCompositedParent", "Is a reflection of a composited layer"},
88 {kCompositingReasonIsolateCompositedDescendants, 88 {kCompositingReasonIsolateCompositedDescendants,
89 "isolateCompositedDescendants", 89 "isolateCompositedDescendants",
90 "Should isolate descendants to apply a blend effect"}, 90 "Should isolate descendants to apply a blend effect"},
91 {kCompositingReasonPositionFixedWithCompositedDescendants, 91 {kCompositingReasonPositionFixedOrStickyWithCompositedDescendants,
92 "positionFixedWithCompositedDescendants" 92 "positionFixedOrStickyWithCompositedDescendants"
93 "Is a position:fixed element with composited descendants"}, 93 "Is a position:fixed or position:sticky element with composited "
94 "descendants"},
94 {kCompositingReasonRoot, "root", "Is the root layer"}, 95 {kCompositingReasonRoot, "root", "Is the root layer"},
95 {kCompositingReasonLayerForAncestorClip, "layerForAncestorClip", 96 {kCompositingReasonLayerForAncestorClip, "layerForAncestorClip",
96 "Secondary layer, applies a clip due to a sibling in the compositing " 97 "Secondary layer, applies a clip due to a sibling in the compositing "
97 "tree"}, 98 "tree"},
98 {kCompositingReasonLayerForDescendantClip, "layerForDescendantClip", 99 {kCompositingReasonLayerForDescendantClip, "layerForDescendantClip",
99 "Secondary layer, to clip descendants of the owning layer"}, 100 "Secondary layer, to clip descendants of the owning layer"},
100 {kCompositingReasonLayerForPerspective, "layerForPerspective", 101 {kCompositingReasonLayerForPerspective, "layerForPerspective",
101 "Secondary layer, to house the perspective transform for all descendants"}, 102 "Secondary layer, to house the perspective transform for all descendants"},
102 {kCompositingReasonLayerForHorizontalScrollbar, 103 {kCompositingReasonLayerForHorizontalScrollbar,
103 "layerForHorizontalScrollbar", 104 "layerForHorizontalScrollbar",
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 if (reasons & kCompositingReasonStringMap[i].reason) { 156 if (reasons & kCompositingReasonStringMap[i].reason) {
156 if (builder.length()) 157 if (builder.length())
157 builder.Append(','); 158 builder.Append(',');
158 builder.Append(kCompositingReasonStringMap[i].short_name); 159 builder.Append(kCompositingReasonStringMap[i].short_name);
159 } 160 }
160 } 161 }
161 return builder.ToString(); 162 return builder.ToString();
162 } 163 }
163 164
164 } // namespace blink 165 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/CompositingReasons.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698