Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: cc/scheduler/compositor_timing_history.h

Issue 2754943002: Reimplement vsync latency UMA to be based on BeginImplFrame rather than BeginMainFrame (Closed)
Patch Set: Changed UMA metric name, removed VsyncTo. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/scheduler/compositor_timing_history.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_SCHEDULER_COMPOSITOR_TIMING_HISTORY_H_ 5 #ifndef CC_SCHEDULER_COMPOSITOR_TIMING_HISTORY_H_
6 #define CC_SCHEDULER_COMPOSITOR_TIMING_HISTORY_H_ 6 #define CC_SCHEDULER_COMPOSITOR_TIMING_HISTORY_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 virtual base::TimeDelta CommitToReadyToActivateDurationEstimate() const; 47 virtual base::TimeDelta CommitToReadyToActivateDurationEstimate() const;
48 virtual base::TimeDelta PrepareTilesDurationEstimate() const; 48 virtual base::TimeDelta PrepareTilesDurationEstimate() const;
49 virtual base::TimeDelta ActivateDurationEstimate() const; 49 virtual base::TimeDelta ActivateDurationEstimate() const;
50 virtual base::TimeDelta DrawDurationEstimate() const; 50 virtual base::TimeDelta DrawDurationEstimate() const;
51 51
52 // State that affects when events should be expected/recorded/reported. 52 // State that affects when events should be expected/recorded/reported.
53 void SetRecordingEnabled(bool enabled); 53 void SetRecordingEnabled(bool enabled);
54 void DidCreateAndInitializeCompositorFrameSink(); 54 void DidCreateAndInitializeCompositorFrameSink();
55 55
56 // Events to be timed. 56 // Events to be timed.
57 void WillBeginImplFrame(bool new_active_tree_is_likely); 57 void WillBeginImplFrame(bool new_active_tree_is_likely,
58 base::TimeTicks frame_time,
59 BeginFrameArgs::BeginFrameArgsType frame_type,
60 base::TimeTicks now);
58 void WillFinishImplFrame(bool needs_redraw); 61 void WillFinishImplFrame(bool needs_redraw);
59 void BeginImplFrameNotExpectedSoon(); 62 void BeginImplFrameNotExpectedSoon();
60 void WillBeginMainFrame(bool on_critical_path, 63 void WillBeginMainFrame(bool on_critical_path,
61 base::TimeTicks main_frame_time, 64 base::TimeTicks main_frame_time);
62 BeginFrameArgs::BeginFrameArgsType frame_type);
63 void BeginMainFrameStarted(base::TimeTicks main_thread_start_time); 65 void BeginMainFrameStarted(base::TimeTicks main_thread_start_time);
64 void BeginMainFrameAborted(); 66 void BeginMainFrameAborted();
65 void DidCommit(); 67 void DidCommit();
66 void WillPrepareTiles(); 68 void WillPrepareTiles();
67 void DidPrepareTiles(); 69 void DidPrepareTiles();
68 void ReadyToActivate(); 70 void ReadyToActivate();
69 void WillActivate(); 71 void WillActivate();
70 void DidActivate(); 72 void DidActivate();
71 void DrawAborted(); 73 void DrawAborted();
72 void WillDraw(); 74 void WillDraw();
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 std::unique_ptr<UMAReporter> uma_reporter_; 127 std::unique_ptr<UMAReporter> uma_reporter_;
126 RenderingStatsInstrumentation* rendering_stats_instrumentation_; 128 RenderingStatsInstrumentation* rendering_stats_instrumentation_;
127 129
128 private: 130 private:
129 DISALLOW_COPY_AND_ASSIGN(CompositorTimingHistory); 131 DISALLOW_COPY_AND_ASSIGN(CompositorTimingHistory);
130 }; 132 };
131 133
132 } // namespace cc 134 } // namespace cc
133 135
134 #endif // CC_SCHEDULER_COMPOSITOR_TIMING_HISTORY_H_ 136 #endif // CC_SCHEDULER_COMPOSITOR_TIMING_HISTORY_H_
OLDNEW
« no previous file with comments | « no previous file | cc/scheduler/compositor_timing_history.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698