Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: src/code-stub-assembler.cc

Issue 2754933003: [string] Optimize ToDirectStringAssembler for sequential strings (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stub-assembler.cc
diff --git a/src/code-stub-assembler.cc b/src/code-stub-assembler.cc
index 63f2462884f421350e33818b4c260c2867c3e5c2..a12587751cc4b8ded25ef17d5e226a92c1dc0ad3 100644
--- a/src/code-stub-assembler.cc
+++ b/src/code-stub-assembler.cc
@@ -3363,7 +3363,8 @@ Node* ToDirectStringAssembler::TryToDirect(Label* if_bailout) {
Label if_isthin(this);
Label out(this);
- Goto(&dispatch);
+ Branch(IsSequentialStringInstanceType(var_instance_type_.value()), &out,
+ &dispatch);
// Dispatch based on string representation.
Bind(&dispatch);
@@ -3440,7 +3441,7 @@ Node* ToDirectStringAssembler::TryToSequential(StringPointerKind ptr_kind,
CHECK(ptr_kind == PTR_TO_DATA || ptr_kind == PTR_TO_STRING);
Variable var_result(this, MachineType::PointerRepresentation());
- Label out(this), if_issequential(this), if_isexternal(this);
+ Label out(this), if_issequential(this), if_isexternal(this, Label::kDeferred);
Branch(is_external(), &if_isexternal, &if_issequential);
Bind(&if_issequential);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698