Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2050)

Unified Diff: chrome/test/data/extensions/api_test/file_manager_browsertest/keyboard_operations.js

Issue 275493006: Files.app: Fix selection on creating new folder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/file_manager_browsertest/keyboard_operations.js
diff --git a/chrome/test/data/extensions/api_test/file_manager_browsertest/keyboard_operations.js b/chrome/test/data/extensions/api_test/file_manager_browsertest/keyboard_operations.js
index 286102d3970d49831cfa17be72c8dba8307edaf4..5b2d92bf404ed83a14f81fb96c195d0a24c637af 100644
--- a/chrome/test/data/extensions/api_test/file_manager_browsertest/keyboard_operations.js
+++ b/chrome/test/data/extensions/api_test/file_manager_browsertest/keyboard_operations.js
@@ -128,63 +128,6 @@ function keyboardDelete(path) {
}
/**
- * Adds check of chrome.test to the end of the given promise.
- * @param {Promise} promise Promise.
- */
-function testPromise(promise) {
- promise.then(function() {
- return new Promise(checkIfNoErrorsOccured);
- }).then(chrome.test.callbackPass(function() {
- // The callbacPass is necessary to avoid prematurely finishing tests.
- // Don't put chrome.test.succeed() here to avoid doubled success log.
- }), function(error) {
- chrome.test.fail(error.stack || error);
- });
-};
-
-/**
- * Test for creating new folder.
- * @param {string} path Initial path.
- * @param {Array.<TestEntryInfo>} initialEntrySet Initial set of entries.
- * @return {Promise} Promise to be fulfilled on success.
- */
-function createNewFolder(path, initialEntrySet) {
- var windowId;
- // Open window.
- return new Promise(function(callback) {
- setupAndWaitUntilReady(null, path, callback);
- }).then(function(inWindowId) {
- windowId = inWindowId;
- // Push Ctrl + E.
- return callRemoteTestUtil('fakeKeyDown',
- windowId,
- // Ctrl + E
- ['#file-list', 'U+0045', true]);
- }).then(function() {
- // Wait for rename text field.
- return waitForElement(windowId, 'input.rename');
- }).then(function() {
- // Type new folder name.
- return callRemoteTestUtil(
- 'inputText', windowId, ['input.rename', 'Test Folder Name']);
- }).then(function() {
- // Push Enter.
- return callRemoteTestUtil('fakeKeyDown',
- windowId,
- ['input.rename', 'Enter', false]);
- }).then(function() {
- return waitForElementLost(windowId, 'input.rename');
- }).then(function() {
- var expectedEntryRows = TestEntryInfo.getExpectedRows(initialEntrySet);
- expectedEntryRows.push(['Test Folder Name', '--', 'Folder', '']);
- // Wait for the new folder.
- return waitForFiles(windowId,
- expectedEntryRows,
- {ignoreLastModifiedTime: true});
- });
-};
-
-/**
* Renames a file.
* @param {string} windowId ID of the window.
* @param {string} oldName Old name of a file.
@@ -273,12 +216,7 @@ testcase.keyboardDeleteDrive = function() {
keyboardDelete(RootPath.DRIVE);
};
-testcase.createNewFolderDownloads = function() {
- testPromise(createNewFolder(RootPath.DOWNLOADS, BASIC_LOCAL_ENTRY_SET));
-};
-
-testcase.createNewFolderDrive = function() {
- testPromise(createNewFolder(RootPath.DRIVE, BASIC_DRIVE_ENTRY_SET));
+testcase.createNewFolderAndCheckFocus = function() {
};
testcase.renameFileDownloads = function() {

Powered by Google App Engine
This is Rietveld 408576698