Tweak corelib files so dartfmt can do a better job. Use // comments to force line wrapping for long…

Tweak corelib files so dartfmt can do a better job. Use // comments to force line wrapping for long array literals to be more reasonable. Switched some /* comments to // comments Fixed cases where comments were not indented correctly when running the formatter was considered.

BUG=
R=floitsch@google.com, lrn@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/ed2d79a8728ab7e2bc3cf274275e31cdc2386ce9

[Jacob, 2017-03-16 17:57:44]

jacobr@google.com changed reviewers:
+ floitsch@google.com

[Jacob, 2017-03-16 17:57:44]

Tweak corelib files so dartfmt can do a better job.
Use // comments to force line wrapping for long array literals to be more
reasonable.
Switched some /* comments to // comments
Fixed cases where comments were not indented correctly when running the
formatter was considered.

[Bob Nystrom, 2017-03-16 18:03:15]

rnystrom@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2017-03-16 18:03:16]

lgtm

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:781: //           ; non-zero-length segment without any
colon ":"
What's up with these changes?

[floitsch, 2017-03-16 18:05:57]

LGTM.
I'm sure Lasse would prefer not to modify the files, but I think this is good
enough.
Thanks.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/convert/base64.dart
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/convert/base64.dart...
sdk/lib/convert/base64.dart:522: __, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12,
13, 14, //
00, 01, 02, ...
This way they should stay aligned.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:2868: ]; // 0x70 - 0x7f  1111111111100010
The last one still needs to be moved one line up.
Consider adding a ',' too.

Same for the others.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:3707: ]; // 0x70 - 0x7f  11111111 11111110
Same here.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/io/crypto.dart
File sdk/lib/io/crypto.dart (right):

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/io/crypto.dart#newc...
sdk/lib/io/crypto.dart:29: -2, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
//
00, 01, ...
Should help keeping them aligned.

[Jacob, 2017-03-16 18:10:46]

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:781: //           ; non-zero-length segment without any
colon ":"
On 2017/03/16 18:03:15, Bob Nystrom wrote:
> What's up with these changes?
Fixed. Testing if you are paying attention. :)
Good news is this was the only file I did some dangerous find and replacing to
get the comments to still line up.

[Lasse Reichstein Nielsen, 2017-03-16 18:38:27]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2017-03-16 18:38:28]

Allow me to say that adding empty comments to work around bad formatting is a
hack, not a solution.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:806: var indices = new List<int>(8); //new
List<int>.filled(8, start - 1);
Note to self: This is commented code, so it should just be removed.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:4228: "Origin is only applicable schemes http and https:
$this");
Hmm, missing a "to" in this message.

https://codereview.chromium.org/2754923002/diff/20001/sdk/lib/convert/base64....
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/2754923002/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:522: __, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12,
13, 14, //
Add a leading zero to the single-digit numbers here.

https://codereview.chromium.org/2754923002/diff/20001/sdk/lib/io/crypto.dart
File sdk/lib/io/crypto.dart (right):

https://codereview.chromium.org/2754923002/diff/20001/sdk/lib/io/crypto.dart#...
sdk/lib/io/crypto.dart:28: 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, -2, -2, -2,
0, -2, -2, //
Add leading zeros to single-digit numbers.

[Jacob, 2017-03-16 19:22:18]

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/convert/base64.dart
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/convert/base64.dart...
sdk/lib/convert/base64.dart:522: __, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12,
13, 14, //
On 2017/03/16 18:05:57, floitsch wrote:
> 00, 01, 02, ...
> This way they should stay aligned.

good idea! done.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:806: var indices = new List<int>(8); //new
List<int>.filled(8, start - 1);
On 2017/03/16 18:38:27, Lasse Reichstein Nielsen wrote:
> Note to self: This is commented code, so it should just be removed.

Removed.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:2868: ]; // 0x70 - 0x7f  1111111111100010
On 2017/03/16 18:05:57, floitsch wrote:
> The last one still needs to be moved one line up.
> Consider adding a ',' too.
> 
> Same for the others.

good catch. fixed.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:4228: "Origin is only applicable schemes http and https:
$this");
On 2017/03/16 18:38:27, Lasse Reichstein Nielsen wrote:
> Hmm, missing a "to" in this message.

Done.

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/io/crypto.dart
File sdk/lib/io/crypto.dart (right):

https://codereview.chromium.org/2754923002/diff/1/sdk/lib/io/crypto.dart#newc...
sdk/lib/io/crypto.dart:29: -2, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
//
On 2017/03/16 18:05:57, floitsch wrote:
> 00, 01, ...
> Should help keeping them aligned.

Done.

https://codereview.chromium.org/2754923002/diff/20001/sdk/lib/convert/base64....
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/2754923002/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:522: __, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12,
13, 14, //
On 2017/03/16 18:38:27, Lasse Reichstein Nielsen wrote:
> Add a leading zero to the single-digit numbers here.

done

https://codereview.chromium.org/2754923002/diff/20001/sdk/lib/io/crypto.dart
File sdk/lib/io/crypto.dart (right):

https://codereview.chromium.org/2754923002/diff/20001/sdk/lib/io/crypto.dart#...
sdk/lib/io/crypto.dart:28: 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, -2, -2, -2,
0, -2, -2, //
On 2017/03/16 18:38:27, Lasse Reichstein Nielsen wrote:
> Add leading zeros to single-digit numbers.

Done.

[Jacob, 2017-03-16 19:24:21]

I agree that adding empty comments to work around bad formatting is a bit of a
hack not a solution.
However, it is pretty straightforward and unsurprising
and still allows the code to be formatted. If a lot of files required using the
hack I would have a problem with it but given it is only needed in a few files
in the whole
code base I think it is worthwhile to enable always running the formatter.

[Lasse Reichstein Nielsen, 2017-03-16 21:15:09]

On 2017/03/16 19:24:21, Jacob wrote:
> I agree that adding empty comments to work around bad formatting is a bit of a
> hack not a solution.
> However, it is pretty straightforward and unsurprising

Let's agree to disagree on the "unsurprising" part (a "//" disables line
breaking! Wat?)

> and still allows the code to be formatted. If a lot of files required using
the
> hack I would have a problem with it but given it is only needed in a few files
> in the whole
> code base I think it is worthwhile to enable always running the formatter.

It's the best current solution, so LGTM.

If we start using the formatter on the platform libraries, I'll probably be more
motivated to actually change it instead of peacefully ignoring it :)

[Jacob, 2017-04-19 14:28:32]

Description was changed from

==========
Tweak corelib files so dartfmt can do a better job. Use // comments to force
line wrapping for long array literals to be more reasonable. Switched some /*
comments to // comments Fixed cases where comments were not indented correctly
when running the formatter was considered.

BUG=
==========

to

==========
Tweak corelib files so dartfmt can do a better job. Use // comments to force
line wrapping for long array literals to be more reasonable. Switched some /*
comments to // comments Fixed cases where comments were not indented correctly
when running the formatter was considered.

BUG=
R=floitsch@google.com, lrn@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ed2d79a8728ab7e2bc3cf274275e31cdc2386ce9
==========

[Jacob, 2017-04-19 14:28:33]

Committed patchset #3 (id:40001) manually as
ed2d79a8728ab7e2bc3cf274275e31cdc2386ce9 (presubmit successful).