extensions/browser/api/networking_private/networking_private_api.cc - Issue 2754903002: Prevent networkingPrivate.forgetNetwork from removing shared configs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_api.cc

Issue 2754903002: Prevent networkingPrivate.forgetNetwork from removing shared configs (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/dbus/fake_shill_profile_client.cc ('K') | « components/sync_wifi/wifi_config_delegate_chromeos_unittest.cc ('k') | extensions/browser/api/networking_private/networking_private_chromeos.h » ('j') | extensions/browser/api/networking_private/networking_private_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_api.cc

diff --git a/extensions/browser/api/networking_private/networking_private_api.cc b/extensions/browser/api/networking_private/networking_private_api.cc

index 7929076fa5fab4227a28dd7d039a09474d9efab2..60a1261d9bde50b70cac2dabe29d44af894ea8b6 100644

--- a/extensions/browser/api/networking_private/networking_private_api.cc

+++ b/extensions/browser/api/networking_private/networking_private_api.cc

@@ -272,6 +272,7 @@ NetworkingPrivateForgetNetworkFunction::Run() {

GetDelegate(browser_context())

->ForgetNetwork(

params->network_guid,

+ CanChangeSharedConfig(extension(), source_context_type()),

base::Bind(&NetworkingPrivateForgetNetworkFunction::Success, this),

base::Bind(&NetworkingPrivateForgetNetworkFunction::Failure, this));

// Success() or Failure() might have been called synchronously at this point.