Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4693)

Unified Diff: chromeos/network/network_configuration_handler.h

Issue 2754903002: Prevent networkingPrivate.forgetNetwork from removing shared configs (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_configuration_handler.h
diff --git a/chromeos/network/network_configuration_handler.h b/chromeos/network/network_configuration_handler.h
index 8c3b222970eac25a227f7a022c2cda3992d8cbbb..48ed0d5aa4cd36aacdab5c9ce47caba2371a9b45 100644
--- a/chromeos/network/network_configuration_handler.h
+++ b/chromeos/network/network_configuration_handler.h
@@ -115,6 +115,15 @@ class CHROMEOS_EXPORT NetworkConfigurationHandler
const base::Closure& callback,
const network_handler::ErrorCallback& error_callback);
+ // Removes the network |service_path| from the profile that contains its
+ // currently active configuration.
+ // See notes on |source| and callbacks in class description above.
+ void RemoveConfigurationFromCurrentProfile(
+ const std::string& service_path,
+ NetworkConfigurationObserver::Source source,
+ const base::Closure& callback,
+ const network_handler::ErrorCallback& error_callback);
+
// Changes the profile for the network |service_path| to |profile_path|.
// See notes on |source| and callbacks in class description above.
void SetNetworkProfile(const std::string& service_path,
@@ -205,6 +214,16 @@ class CHROMEOS_EXPORT NetworkConfigurationHandler
// Signals the device handler to request an IP config refresh.
void RequestRefreshIPConfigs(const std::string& service_path);
+ // Removes network configuration for |service_path| from the profile specified
+ // by |profile_path|. If |profile_path| is not set, the network is removed
+ // from all the profiles that include it.
+ void RemoveConfigurationFromProfile(
+ const std::string& service_path,
+ const std::string& profile_path,
+ NetworkConfigurationObserver::Source source,
+ const base::Closure& callback,
+ const network_handler::ErrorCallback& error_callback);
+
// Unowned associated Network*Handlers (global or test instance).
NetworkStateHandler* network_state_handler_;
NetworkDeviceHandler* network_device_handler_;

Powered by Google App Engine
This is Rietveld 408576698