Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 275483005: Fix initial focus, and the way elements are disabled on the 'Clear browsing data' dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed final round of comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/clear_browser_data_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc
diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
index 6b0e5e4907c029449a613b625e93befc2c09bee9..9283e548abc655a51fc3afd47cbee5d0178eaedd 100644
--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
@@ -55,10 +55,12 @@ void ClearBrowserDataHandler::InitializeHandler() {
void ClearBrowserDataHandler::InitializePage() {
UpdateInfoBannerVisibility();
OnBrowsingHistoryPrefChanged();
-
bool removal_in_progress = !!remover_;
web_ui()->CallJavascriptFunction("ClearBrowserDataOverlay.setClearing",
base::FundamentalValue(removal_in_progress));
+
+ web_ui()->CallJavascriptFunction(
+ "ClearBrowserDataOverlay.markInitializationComplete");
}
void ClearBrowserDataHandler::UpdateInfoBannerVisibility() {
@@ -216,7 +218,7 @@ void ClearBrowserDataHandler::OnBrowsingDataRemoverDone() {
void ClearBrowserDataHandler::OnBrowsingHistoryPrefChanged() {
web_ui()->CallJavascriptFunction(
- "ClearBrowserDataOverlay.updateHistoryCheckboxes",
+ "ClearBrowserDataOverlay.setAllowDeletingHistory",
base::FundamentalValue(*allow_deleting_browser_history_));
}
« no previous file with comments | « chrome/browser/ui/webui/options/clear_browser_data_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698