Cache force-installed apps/extensions in device-local accounts

chrome/browser/chromeos/settings/device_settings_test_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_settings_test_helper.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
@@ skipping 45 matching lines @@
   callbacks.swap(device_policy_.retrieve_callbacks_);
   for (std::vector<RetrievePolicyCallback>::iterator cb(callbacks.begin());
        cb != callbacks.end(); ++cb) {
     cb->Run(device_policy_.policy_blob_);
   }
 
   std::map<std::string, PolicyState>::iterator device_local_account_state;
   for (device_local_account_state = device_local_account_policy_.begin();
        device_local_account_state != device_local_account_policy_.end();
        ++device_local_account_state) {
+    std::vector<RetrievePolicyCallback> callbacks;

[Joao da Silva, 2013/10/17 14:57:54]

Another nice catch :-)

Another option here: callbacks.clear()

[bartfab (slow), 2013/10/18 12:58:39]

I prefer creating a new object as it conveys best what this is - a brand new
list, starting out blank.

     callbacks.swap(device_local_account_state->second.retrieve_callbacks_);
     for (std::vector<RetrievePolicyCallback>::iterator cb(callbacks.begin());
          cb != callbacks.end(); ++cb) {
       cb->Run(device_local_account_state->second.policy_blob_);
     }
   }
 }
 
 void DeviceSettingsTestHelper::Flush() {
   do {
@@ skipping 153 matching lines @@
 void DeviceSettingsTestBase::FlushDeviceSettings() {
   device_settings_test_helper_.Flush();
 }
 
 void DeviceSettingsTestBase::ReloadDeviceSettings() {
   device_settings_service_.OwnerKeySet(true);
   FlushDeviceSettings();
 }
 
 }  // namespace chromeos