Enable the EnablePhysicalWeb flag by default on Chrome for iOS

Enable the EnablePhysicalWeb flag by default on Chrome for iOS

With this CL, the Physical Web feature will be available by default on
Chrome for iOS M59 and later. Previously it needed to be enabled by a
Finch configuration or by manually toggling in chrome://flags.

BUG=630769

[mattreynolds, 2017-03-17 19:47:07]

Description was changed from

==========
Enable the EnablePhysicalWeb flag by default on Chrome for iOS

With this CL, the Physical Web feature will be available by default on
Chrome for iOS M59 and later. Previously it needed to be enabled by a
Finch configuration or by manually toggling in chrome://flags.

BUG=630769
==========

to

==========
Enable the EnablePhysicalWeb flag by default on Chrome for iOS

With this CL, the Physical Web feature will be available by default on
Chrome for iOS M59 and later. Previously it needed to be enabled by a
Finch configuration or by manually toggling in chrome://flags.

BUG=630769
==========

[mattreynolds, 2017-03-17 19:47:07]

mattreynolds@chromium.org changed reviewers:
+ sdefresne@chromium.org

[mattreynolds, 2017-03-17 19:48:03]

Hi Sylvain, is this the correct way to enable a Finch flag by default on Bling?
Setting a default in Experimental.plist didn't work.

[sdefresne, 2017-03-20 14:05:47]

The code looks good.

Regarding the Experimental.plist, the file is not shipped with releases meaning
all values are assumed to be false. If you want to enable the feature by
default, you need to change the Experimental.plist entry from EnableFoo to
DisableFoo (yeah, this will be a double-negation) if you've used a boolean, or
change the meaning of the default value (if you used a three value selector.

rohitrao: do we have a documentation we can point people that want to use
finch/experimental flags/about flags?

[sdefresne, 2017-03-20 14:06:05]

lgtm

[mattreynolds, 2017-03-20 17:59:11]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2017-03-20 17:59:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 18:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 18:28:00]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)