third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp - Issue 2754723004: Replace RELEASE_ASSERT with CHECK in core/layout/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

Issue 2754723004: Replace RELEASE_ASSERT with CHECK in core/layout/ (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

diff --git a/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp b/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

index f64728ec24add073464eb302cb936c783dc2e3f5..a804673647f26f3c393bba2a95e59c596b5cefc6 100644

--- a/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

+++ b/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

@@ -36,11 +36,11 @@

namespace blink {

SubtreeLayoutScope::SubtreeLayoutScope(LayoutObject& root) : m_root(root) {

- RELEASE_ASSERT(m_root.document().view()->isInPerformLayout());

+ CHECK(m_root.document().view()->isInPerformLayout());

}

SubtreeLayoutScope::~SubtreeLayoutScope() {

- RELEASE_ASSERT(!m_root.needsLayout());

+ CHECK(!m_root.needsLayout());

#if DCHECK_IS_ON()

for (auto* layoutObject : m_layoutObjectsToLayout)