Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2754723004: Replace RELEASE_ASSERT with CHECK in core/layout/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2082 matching lines...) Expand 10 before | Expand all | Expand 10 after
2093 if (!documentBeingDestroyed()) 2093 if (!documentBeingDestroyed())
2094 m_inlineBoxWrapper->remove(); 2094 m_inlineBoxWrapper->remove();
2095 m_inlineBoxWrapper->destroy(); 2095 m_inlineBoxWrapper->destroy();
2096 m_inlineBoxWrapper = nullptr; 2096 m_inlineBoxWrapper = nullptr;
2097 } 2097 }
2098 } 2098 }
2099 2099
2100 void LayoutBox::setSpannerPlaceholder( 2100 void LayoutBox::setSpannerPlaceholder(
2101 LayoutMultiColumnSpannerPlaceholder& placeholder) { 2101 LayoutMultiColumnSpannerPlaceholder& placeholder) {
2102 // Not expected to change directly from one spanner to another. 2102 // Not expected to change directly from one spanner to another.
2103 RELEASE_ASSERT(!m_rareData || !m_rareData->m_spannerPlaceholder); 2103 CHECK(!m_rareData || !m_rareData->m_spannerPlaceholder);
2104 ensureRareData().m_spannerPlaceholder = &placeholder; 2104 ensureRareData().m_spannerPlaceholder = &placeholder;
2105 } 2105 }
2106 2106
2107 void LayoutBox::clearSpannerPlaceholder() { 2107 void LayoutBox::clearSpannerPlaceholder() {
2108 if (!m_rareData) 2108 if (!m_rareData)
2109 return; 2109 return;
2110 m_rareData->m_spannerPlaceholder = nullptr; 2110 m_rareData->m_spannerPlaceholder = nullptr;
2111 } 2111 }
2112 2112
2113 void LayoutBox::setPaginationStrut(LayoutUnit strut) { 2113 void LayoutBox::setPaginationStrut(LayoutUnit strut) {
(...skipping 3636 matching lines...) Expand 10 before | Expand all | Expand 10 after
5750 5750
5751 void LayoutBox::MutableForPainting:: 5751 void LayoutBox::MutableForPainting::
5752 savePreviousContentBoxSizeAndLayoutOverflowRect() { 5752 savePreviousContentBoxSizeAndLayoutOverflowRect() {
5753 auto& rareData = layoutBox().ensureRareData(); 5753 auto& rareData = layoutBox().ensureRareData();
5754 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true; 5754 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true;
5755 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size(); 5755 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size();
5756 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect(); 5756 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect();
5757 } 5757 }
5758 5758
5759 } // namespace blink 5759 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698