Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2754723004: Replace RELEASE_ASSERT with CHECK in core/layout/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc.
6 * All rights reserved. 6 * All rights reserved.
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 LayoutObject* beforeDescendant) { 292 LayoutObject* beforeDescendant) {
293 ASSERT(beforeDescendant->parent() != this); 293 ASSERT(beforeDescendant->parent() != this);
294 LayoutObject* beforeDescendantContainer = beforeDescendant->parent(); 294 LayoutObject* beforeDescendantContainer = beforeDescendant->parent();
295 while (beforeDescendantContainer->parent() != this) 295 while (beforeDescendantContainer->parent() != this)
296 beforeDescendantContainer = beforeDescendantContainer->parent(); 296 beforeDescendantContainer = beforeDescendantContainer->parent();
297 ASSERT(beforeDescendantContainer); 297 ASSERT(beforeDescendantContainer);
298 298
299 // We really can't go on if what we have found isn't anonymous. We're not 299 // We really can't go on if what we have found isn't anonymous. We're not
300 // supposed to use some random non-anonymous object and put the child there. 300 // supposed to use some random non-anonymous object and put the child there.
301 // That's a recipe for security issues. 301 // That's a recipe for security issues.
302 RELEASE_ASSERT(beforeDescendantContainer->isAnonymous()); 302 CHECK(beforeDescendantContainer->isAnonymous());
303 303
304 // If the requested insertion point is not one of our children, then this is 304 // If the requested insertion point is not one of our children, then this is
305 // because there is an anonymous container within this object that contains 305 // because there is an anonymous container within this object that contains
306 // the beforeDescendant. 306 // the beforeDescendant.
307 if (beforeDescendantContainer->isAnonymousBlock() 307 if (beforeDescendantContainer->isAnonymousBlock()
308 // Full screen layoutObjects and full screen placeholders act as anonymous 308 // Full screen layoutObjects and full screen placeholders act as anonymous
309 // blocks, not tables: 309 // blocks, not tables:
310 || beforeDescendantContainer->isLayoutFullScreen() || 310 || beforeDescendantContainer->isLayoutFullScreen() ||
311 beforeDescendantContainer->isLayoutFullScreenPlaceholder()) { 311 beforeDescendantContainer->isLayoutFullScreenPlaceholder()) {
312 // Insert the child into the anonymous block box instead of here. 312 // Insert the child into the anonymous block box instead of here.
(...skipping 1914 matching lines...) Expand 10 before | Expand all | Expand 10 after
2227 } 2227 }
2228 2228
2229 return availableHeight; 2229 return availableHeight;
2230 } 2230 }
2231 2231
2232 bool LayoutBlock::hasDefiniteLogicalHeight() const { 2232 bool LayoutBlock::hasDefiniteLogicalHeight() const {
2233 return availableLogicalHeightForPercentageComputation() != LayoutUnit(-1); 2233 return availableLogicalHeightForPercentageComputation() != LayoutUnit(-1);
2234 } 2234 }
2235 2235
2236 } // namespace blink 2236 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698