third_party/WebKit/Source/core/events/CustomEvent.idl - Issue 2754713002: Make CustomEvent#initCustomEvent match the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/CustomEvent.idl

Issue 2754713002: Make CustomEvent#initCustomEvent match the spec (Closed)

Patch Set: Codereview: nit Update tests expect after rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/events/CustomEvent.idl

diff --git a/third_party/WebKit/Source/core/events/CustomEvent.idl b/third_party/WebKit/Source/core/events/CustomEvent.idl

index d0c6ee9bbd893aa886cec04d88e323dc52eabae1..0e582610fb683224dafe09eec3a92294cea438fc 100644

--- a/third_party/WebKit/Source/core/events/CustomEvent.idl

+++ b/third_party/WebKit/Source/core/events/CustomEvent.idl

@@ -33,5 +33,5 @@

] interface CustomEvent : Event {

[Custom=Getter] readonly attribute any detail;

- [Measure,Custom=(CallEpilogue)] void initCustomEvent(DOMString type, boolean bubbles, boolean cancelable, any detail);

+ [Measure,Custom=(CallEpilogue)] void initCustomEvent(DOMString type, optional boolean bubbles = false, optional boolean cancelable = false, optional any detail = null);

};

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | no next file » | no next file with comments »