Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 275463002: Unbreak samples and tools. (Closed)

Created:
6 years, 7 months ago by Sven Panne
Modified:
6 years, 7 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Unbreak samples and tools. Removed a related TODO in d8.cc on the way. BUG=v8::3318 LOG=y R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -23 lines) Patch
M samples/lineprocessor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/process.cc View 1 chunk +2 lines, -1 line 0 comments Download
M samples/shell.cc View 1 chunk +15 lines, -3 lines 0 comments Download
M src/d8.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M tools/lexer-shell.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/parser-shell.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 7 months ago (2014-05-07 13:25:54 UTC) #1
dcarney
lgtm
6 years, 7 months ago (2014-05-07 13:49:10 UTC) #2
Sven Panne
6 years, 7 months ago (2014-05-08 06:52:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21195 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698