Issue 2754583002: Fix equality invocation on native objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2754583002: Fix equality invocation on native objects (Closed)

Created:
3 years, 9 months ago by vsm

Modified:
3 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	tests/lib_strong/html/client_rect_test.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

vsm

Note, this does update the generated files, but those don't seem to upload.

3 years, 9 months ago (2017-03-14 22:09:49 UTC) #2

Jennifer Messerly

LGTM. I think originally we were planning to just put '==' as a property on ...

3 years, 9 months ago (2017-03-14 22:22:28 UTC) #3

vsm

3 years, 9 months ago (2017-03-14 22:27:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ee6f4608479723687002d5671bf586827cafac24 (presubmit successful).