Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1836)

Unified Diff: chrome/test/data/webui/settings/help_page_browsertest.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/help_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/help_page_browsertest.js b/chrome/test/data/webui/settings/help_page_browsertest.js
index 2925dfbc0713948229630687dfdee2833658b31f..6e04109054d501244430d5c57afb3bda9ad50c8d 100644
--- a/chrome/test/data/webui/settings/help_page_browsertest.js
+++ b/chrome/test/data/webui/settings/help_page_browsertest.js
@@ -24,6 +24,12 @@ SettingsHelpPageBrowserTest.prototype = {
/** @override */
extraLibraries: PolymerTest.getLibraries(ROOT_PATH),
+
+ /** @override */
+ setUp: function() {
+ // Intentionally bypassing SettingsPageBrowserTest#setUp.
+ PolymerTest.prototype.setUp.call(this);
+ },
};
TEST_F('SettingsHelpPageBrowserTest', 'Load', function() {
@@ -34,8 +40,9 @@ TEST_F('SettingsHelpPageBrowserTest', 'Load', function() {
// Register mocha tests.
suite('Help page', function() {
test('about section', function() {
- var page = self.getPage('about');
- expectTrue(!!self.getSection(page, 'about'));
+ return self.getPage('about').then(function(page) {
+ expectTrue(!!self.getSection(page, 'about'));
+ });
});
});
« no previous file with comments | « chrome/test/data/webui/settings/ensure_lazy_loaded.js ('k') | chrome/test/data/webui/settings/languages_page_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698