chrome/browser/resources/settings/settings_page/main_page_behavior.js - Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)

Patch Set: Address comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.js ('k') | chrome/browser/resources/settings/settings_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js

diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

index 8fdf5f7e6e61f2e949d67e6f8acaa3df9fce936d..6e7fe98eea12454d25a57f389bd44ffe39f58c40 100644

--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js

+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

@@ -116,6 +116,11 @@ var MainPageBehaviorImpl = {

promise = this.expandSection_(currentSection);

else if (scrollToSection)

currentSection.scrollIntoView();

+ } else if (settings.Route.ADVANCED.contains(currentRoute) &&

+ // Need to exclude routes that correspond to 'non-sectioned' children of

+ // ADVANCED, otherwise tryTransitionToSection_ will recurse endlessly.

+ !currentRoute.isNavigableDialog) {

+ promise = this.$$('#advancedPageTemplate').get();

}

// When this animation ends, another may be necessary. Call this function