Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/basic_page/basic_page.html ('k') | chrome/browser/resources/settings/controls/settings_idle_load.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/basic_page/basic_page.js
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js
index 840b2f41d522cb3e4d3f20ea5a3c2d38bed3e24e..d360e891f428705bfcc79d468745f7fb91989688 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.js
+++ b/chrome/browser/resources/settings/basic_page/basic_page.js
@@ -114,8 +114,10 @@ Polymer({
];
if (this.pageVisibility.advancedSettings !== false) {
- whenSearchDone.push(settings.getSearchManager().search(
- query, assert(this.$$('#advancedPageTemplate').get())));
+ whenSearchDone.push(this.$$('#advancedPageTemplate').get().then(
+ function(advancedPage) {
+ return settings.getSearchManager().search(query, advancedPage);
+ }));
}
return Promise.all(whenSearchDone).then(function(requests) {
« no previous file with comments | « chrome/browser/resources/settings/basic_page/basic_page.html ('k') | chrome/browser/resources/settings/controls/settings_idle_load.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698