Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/test/data/webui/settings/help_page_browsertest.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Fix tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/help_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/help_page_browsertest.js b/chrome/test/data/webui/settings/help_page_browsertest.js
index 2925dfbc0713948229630687dfdee2833658b31f..54c841706a786427830d3a446cc742a2efe2e969 100644
--- a/chrome/test/data/webui/settings/help_page_browsertest.js
+++ b/chrome/test/data/webui/settings/help_page_browsertest.js
@@ -24,6 +24,11 @@ SettingsHelpPageBrowserTest.prototype = {
/** @override */
extraLibraries: PolymerTest.getLibraries(ROOT_PATH),
+
+ /** @override */
+ setUp: function() {
Dan Beam 2017/03/18 00:15:51 please add a note that you're intentionally bypass
dpapad 2017/03/20 20:34:55 Done.
+ PolymerTest.prototype.setUp.call(this);
+ },
};
TEST_F('SettingsHelpPageBrowserTest', 'Load', function() {
@@ -34,8 +39,9 @@ TEST_F('SettingsHelpPageBrowserTest', 'Load', function() {
// Register mocha tests.
suite('Help page', function() {
test('about section', function() {
- var page = self.getPage('about');
- expectTrue(!!self.getSection(page, 'about'));
+ return self.getPage('about').then(function(page) {
+ expectTrue(!!self.getSection(page, 'about'));
+ });
});
});

Powered by Google App Engine
This is Rietveld 408576698