Chromium Code Reviews| Index: chrome/test/data/webui/settings/help_page_browsertest.js |
| diff --git a/chrome/test/data/webui/settings/help_page_browsertest.js b/chrome/test/data/webui/settings/help_page_browsertest.js |
| index 2925dfbc0713948229630687dfdee2833658b31f..54c841706a786427830d3a446cc742a2efe2e969 100644 |
| --- a/chrome/test/data/webui/settings/help_page_browsertest.js |
| +++ b/chrome/test/data/webui/settings/help_page_browsertest.js |
| @@ -24,6 +24,11 @@ SettingsHelpPageBrowserTest.prototype = { |
| /** @override */ |
| extraLibraries: PolymerTest.getLibraries(ROOT_PATH), |
| + |
| + /** @override */ |
| + setUp: function() { |
|
Dan Beam
2017/03/17 00:30:05
why can't we just make .basicPage null in tests?
dpapad
2017/03/17 20:53:55
Not fully understanding the suggestion. Overriding
|
| + PolymerTest.prototype.setUp.call(this); |
| + }, |
| }; |
| TEST_F('SettingsHelpPageBrowserTest', 'Load', function() { |
| @@ -34,8 +39,9 @@ TEST_F('SettingsHelpPageBrowserTest', 'Load', function() { |
| // Register mocha tests. |
| suite('Help page', function() { |
| test('about section', function() { |
| - var page = self.getPage('about'); |
| - expectTrue(!!self.getSection(page, 'about')); |
| + return self.getPage('about').then(function(page) { |
| + expectTrue(!!self.getSection(page, 'about')); |
| + }); |
| }); |
| }); |