Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** @fileoverview Suite of tests for settings-languages-page. */ 5 /** @fileoverview Suite of tests for settings-languages-page. */
6 6
7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */ 7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
8 var ROOT_PATH = '../../../../../'; 8 var ROOT_PATH = '../../../../../';
9 9
10 // Polymer BrowserTest fixture. 10 // Polymer BrowserTest fixture.
(...skipping 25 matching lines...) Expand all
36 // the Settings page can take several seconds to load in a Release build 36 // the Settings page can take several seconds to load in a Release build
37 // and several times that in a Debug build. See https://crbug.com/558434. 37 // and several times that in a Debug build. See https://crbug.com/558434.
38 GEN('#if defined(OS_WINDOWS) || defined(MEMORY_SANITIZER) || !defined(NDEBUG)'); 38 GEN('#if defined(OS_WINDOWS) || defined(MEMORY_SANITIZER) || !defined(NDEBUG)');
39 GEN('#define MAYBE_LanguagesPage DISABLED_LanguagesPage'); 39 GEN('#define MAYBE_LanguagesPage DISABLED_LanguagesPage');
40 GEN('#else'); 40 GEN('#else');
41 GEN('#define MAYBE_LanguagesPage LanguagesPage'); 41 GEN('#define MAYBE_LanguagesPage LanguagesPage');
42 GEN('#endif'); 42 GEN('#endif');
43 43
44 // Runs languages page tests. 44 // Runs languages page tests.
45 TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() { 45 TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
46 var self = this;
47
48 suiteSetup(function() {
49 self.toggleAdvanced();
50 });
51
46 suite('languages page', function() { 52 suite('languages page', function() {
47 testing.Test.disableAnimationsAndTransitions(); 53 testing.Test.disableAnimationsAndTransitions();
48 54
49 this.toggleAdvanced();
50 var page = this.getPage('basic');
51
52 var languagesSection; 55 var languagesSection;
53 var languagesPage; 56 var languagesPage;
54 var languagesCollapse; 57 var languagesCollapse;
55 var languageHelper; 58 var languageHelper;
56 var actionMenu; 59 var actionMenu;
57 60
58 /** 61 /**
59 * @param {numExpected} Expected number of languages to eventually be 62 * @param {numExpected} Expected number of languages to eventually be
60 * enabled. 63 * enabled.
61 * @return {!Promise} Resolved when the number of enabled languages changes 64 * @return {!Promise} Resolved when the number of enabled languages changes
(...skipping 12 matching lines...) Expand all
74 } 77 }
75 78
76 // Returns supported languages that are not enabled. 79 // Returns supported languages that are not enabled.
77 function getAvailableLanguages() { 80 function getAvailableLanguages() {
78 return languagesPage.languages.supported.filter(function(language) { 81 return languagesPage.languages.supported.filter(function(language) {
79 return !languageHelper.isLanguageEnabled(language.code); 82 return !languageHelper.isLanguageEnabled(language.code);
80 }); 83 });
81 } 84 }
82 85
83 suiteSetup(function() { 86 suiteSetup(function() {
87 var page = self.basicPage;
84 page.set('pageVisibility.languages', true); 88 page.set('pageVisibility.languages', true);
85 Polymer.dom.flush(); 89 Polymer.dom.flush();
86 90
87 languagesSection = assert(this.getSection(page, 'languages')); 91 languagesSection = assert(this.getSection(page, 'languages'));
88 languagesPage = assert( 92 languagesPage = assert(
89 languagesSection.querySelector('settings-languages-page')); 93 languagesSection.querySelector('settings-languages-page'));
90 languagesCollapse = languagesPage.$.languagesCollapse; 94 languagesCollapse = languagesPage.$.languagesCollapse;
91 languagesCollapse.opened = true; 95 languagesCollapse.opened = true;
92 actionMenu = languagesPage.$.menu.get(); 96 actionMenu = languagesPage.$.menu.get();
93 97
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 0, triggerRow.querySelector('.secondary').textContent.length); 453 0, triggerRow.querySelector('.secondary').textContent.length);
450 } 454 }
451 }); 455 });
452 }.bind(this)); 456 }.bind(this));
453 457
454 // TODO(michaelpg): Test more aspects of the languages UI. 458 // TODO(michaelpg): Test more aspects of the languages UI.
455 459
456 // Run all registered tests. 460 // Run all registered tests.
457 mocha.run(); 461 mocha.run();
458 }); 462 });
OLDNEW
« no previous file with comments | « chrome/test/data/webui/settings/help_page_browsertest.js ('k') | chrome/test/data/webui/settings/on_startup_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698