Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="../appearance_page/appearance_page.html"> 2 <link rel="import" href="../appearance_page/appearance_page.html">
3 <link rel="import" href="../controls/settings_idle_render.html"> 3 <link rel="import" href="../controls/settings_idle_load.html">
4 <link rel="import" href="../lazy_load.html">
5 <link rel="import" href="../on_startup_page/on_startup_page.html"> 4 <link rel="import" href="../on_startup_page/on_startup_page.html">
6 <link rel="import" href="../people_page/people_page.html"> 5 <link rel="import" href="../people_page/people_page.html">
7 <link rel="import" href="../reset_page/reset_profile_banner.html"> 6 <link rel="import" href="../reset_page/reset_profile_banner.html">
8 <link rel="import" href="../search_page/search_page.html"> 7 <link rel="import" href="../search_page/search_page.html">
9 <link rel="import" href="../settings_page/main_page_behavior.html"> 8 <link rel="import" href="../settings_page/main_page_behavior.html">
10 <link rel="import" href="../settings_page/settings_page_visibility.html"> 9 <link rel="import" href="../settings_page/settings_page_visibility.html">
11 <link rel="import" href="../settings_page/settings_section.html"> 10 <link rel="import" href="../settings_page/settings_section.html">
12 <link rel="import" href="../settings_page_css.html"> 11 <link rel="import" href="../settings_page_css.html">
13 <link rel="import" href="../settings_vars_css.html"> 12 <link rel="import" href="../settings_vars_css.html">
14 13
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 <h2 id="toggleContainer"> 174 <h2 id="toggleContainer">
176 <paper-button id="advancedToggle" active="{{advancedToggleExpanded}}" 175 <paper-button id="advancedToggle" active="{{advancedToggleExpanded}}"
177 aria-active-attribute="aria-expanded" toggles> 176 aria-active-attribute="aria-expanded" toggles>
178 <span>$i18n{advancedPageTitle}</span> 177 <span>$i18n{advancedPageTitle}</span>
179 <iron-icon icon="[[getArrowIcon_(advancedToggleExpanded)]]"> 178 <iron-icon icon="[[getArrowIcon_(advancedToggleExpanded)]]">
180 </iron-icon> 179 </iron-icon>
181 </paper-button> 180 </paper-button>
182 </h2> 181 </h2>
183 </template> 182 </template>
184 183
185 <template is="settings-idle-render" id="advancedPageTemplate"> 184 <template is="settings-idle-load" id="advancedPageTemplate"
185 url="/lazy_load.html">
186 <div id="advancedPage" hidden$="[[!showAdvancedPage_( 186 <div id="advancedPage" hidden$="[[!showAdvancedPage_(
187 currentRoute_, inSearchMode, hasExpandedSection_, 187 currentRoute_, inSearchMode, hasExpandedSection_,
188 advancedToggleExpanded)]]"> 188 advancedToggleExpanded)]]">
189 <if expr="chromeos"> 189 <if expr="chromeos">
190 <template is="dom-if" if="[[showPage(pageVisibility.dateTime)]]" 190 <template is="dom-if" if="[[showPage(pageVisibility.dateTime)]]"
191 restamp> 191 restamp>
192 <settings-section page-title="$i18n{dateTimePageTitle}" 192 <settings-section page-title="$i18n{dateTimePageTitle}"
193 section="dateTime"> 193 section="dateTime">
194 <settings-date-time-page prefs="{{prefs}}" 194 <settings-date-time-page prefs="{{prefs}}"
195 page-visibility="[[pageVisibility.dateTime]]"> 195 page-visibility="[[pageVisibility.dateTime]]">
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 section="reset"> 260 section="reset">
261 <settings-reset-page></settings-reset-page> 261 <settings-reset-page></settings-reset-page>
262 </settings-section> 262 </settings-section>
263 </template> 263 </template>
264 </div> 264 </div>
265 </template> 265 </template>
266 </template> 266 </template>
267 </template> 267 </template>
268 <script src="basic_page.js"></script> 268 <script src="basic_page.js"></script>
269 </dom-module> 269 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698