MD Settings: Lazy load the contents of the "advanced" settings.

chrome/browser/resources/settings/route.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /**
    * Class for navigable routes. May only be instantiated within this file.
    * @constructor
    * @param {string} path
    * @private
@@ skipping 82 matching lines @@
 
   // Navigable dialogs. These are the only non-section children of root pages.
   // These are disfavored. If we add anymore, we should add explicit support.
   r.IMPORT_DATA = r.BASIC.createChild('/importData');
   r.SIGN_OUT = r.BASIC.createChild('/signOut');
   r.CLEAR_BROWSER_DATA = r.ADVANCED.createChild('/clearBrowserData');
   r.RESET_DIALOG = r.ADVANCED.createChild('/resetProfileSettings');
   r.TRIGGERED_RESET_DIALOG =
       r.ADVANCED.createChild('/triggeredResetProfileSettings');
 
+  var navigableDialogs = new Set([
+    r.CLEAR_BROWSER_DATA,
+    r.IMPORT_DATA,
+    r.RESET_DIALOG,
+    r.SIGN_OUT,
+    r.TRIGGERED_RESET_DIALOG,
+  ]);

[tommycli, 2017/03/21 16:44:57]

the isNavigableDialog thing is fine. I may suggest instead making it a property
of the route itself that defaults ta false... i.e.

if (route.isNavigableDialog) -- just so it's declared in the line right after
the route (so it's impossible to miss putting it in the Set), but it's not a
huge deal either way.

[dpapad, 2017/03/21 17:54:15]

Done.

+
 // <if expr="chromeos">
   r.INTERNET = r.BASIC.createSection('/internet', 'internet');
   r.INTERNET_NETWORKS = r.INTERNET.createChild('/networks');
   r.NETWORK_DETAIL = r.INTERNET.createChild('/networkDetail');
   r.KNOWN_NETWORKS = r.INTERNET.createChild('/knownNetworks');
   r.BLUETOOTH = r.BASIC.createSection('/bluetooth', 'bluetooth');
   r.BLUETOOTH_DEVICES = r.BLUETOOTH.createChild('/bluetoothDevices');
 // </if>
 
   r.APPEARANCE = r.BASIC.createSection('/appearance', 'appearance');
@@ skipping 277 matching lines @@
     else
       navigateTo(currentRoute_.parent || Route.BASIC);
   };
 
   window.addEventListener('popstate', function(event) {
     // On pop state, do not push the state onto the window.history again.
     setCurrentRoute(getRouteForPath(window.location.pathname) || Route.BASIC,
                     new URLSearchParams(window.location.search), true);
   });
 
+  /**
+   * @param {!Route}

[Dan Beam, 2017/03/21 08:16:12]

@param {!Route} route

[dpapad, 2017/03/21 17:54:15]

Done.

+   * @return {boolean} Whether the given route corresponds to a navigable
+   *     dialog. Those routes don't belong to a "section".
+   */
+  function isNavigableDialog(route) {
+    return navigableDialogs.has(route);
+  }
+
   return {
     Route: Route,
     RouteObserverBehavior: RouteObserverBehavior,
     getRouteForPath: getRouteForPath,
     initializeRouteFromUrl: initializeRouteFromUrl,
     resetRouteForTesting: resetRouteForTesting,
     getCurrentRoute: getCurrentRoute,
     getQueryParameters: getQueryParameters,
     lastRouteChangeWasPopstate: lastRouteChangeWasPopstate,
     navigateTo: navigateTo,
     navigateToPreviousRoute: navigateToPreviousRoute,
+    isNavigableDialog: isNavigableDialog,
   };
 });