Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/test/data/webui/settings/ensure_lazy_loaded.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Fix direct navigation to lazy loaded sections and overscrolling. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 cr.define('settings', function() {
6
Dan Beam 2017/03/17 00:31:43 nit: no \n
dpapad 2017/03/17 20:53:55 Done.
7 function ensureLazyLoaded() {
8 // Only trigger lazy loading, if we are in top-level Settings page.
9 if (window.location.href == 'chrome://md-settings/') {
Dan Beam 2017/03/17 00:31:43 nit: if (location.href == location.origin) { gets
dpapad 2017/03/17 20:53:55 Done.
10 suiteSetup(function() {
11 return new Promise(function(resolve, reject) {
Dan Beam 2017/03/17 00:31:43 nit: mention this needs to be basically exactly th
dpapad 2017/03/17 20:53:55 Done.
12 Polymer.Base.importHref('/lazy_load.html', resolve, reject, true);
13 });
14 });
15 }
16 }
17
18 return {
19 ensureLazyLoaded: ensureLazyLoaded,
20 };
21 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698