Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Fix direct navigation to lazy loaded sections and overscrolling. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{about: boolean, settings: boolean}} 6 * @typedef {{about: boolean, settings: boolean}}
7 */ 7 */
8 var MainPageVisibility; 8 var MainPageVisibility;
9 9
10 /** 10 /**
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 type: Object, 78 type: Object,
79 value: function() { return {}; }, 79 value: function() { return {}; },
80 }, 80 },
81 81
82 showAndroidApps: Boolean, 82 showAndroidApps: Boolean,
83 }, 83 },
84 84
85 /** @override */ 85 /** @override */
86 attached: function() { 86 attached: function() {
87 this.listen(this, 'freeze-scroll', 'onFreezeScroll_'); 87 this.listen(this, 'freeze-scroll', 'onFreezeScroll_');
88 this.listen(this, 'lazy-loaded', 'onLazyLoaded_');
Dan Beam 2017/03/17 00:30:05 use listeners: or unlisten in detached()?
dpapad 2017/03/17 20:53:54 I am pretty sure listen() already takes care of un
89 },
90
91 /** @private */
92 onLazyLoaded_: function() {
93 Polymer.dom.flush();
94 this.updateOverscrollForPage_();
88 }, 95 },
89 96
90 /** @override */ 97 /** @override */
91 detached: function() { 98 detached: function() {
92 this.unlisten(this, 'freeze-scroll', 'onFreezeScroll_'); 99 this.unlisten(this, 'freeze-scroll', 'onFreezeScroll_');
93 }, 100 },
94 101
95 /** @private */ 102 /** @private */
96 overscrollChanged_: function() { 103 overscrollChanged_: function() {
97 if (!this.overscroll_ && this.boundScroll_) { 104 if (!this.overscroll_ && this.boundScroll_) {
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 text: this.showNoResultsFound_ ? 281 text: this.showNoResultsFound_ ?
275 loadTimeData.getString('searchNoResults') : 282 loadTimeData.getString('searchNoResults') :
276 loadTimeData.getStringF('searchResults', query) 283 loadTimeData.getStringF('searchResults', query)
277 }); 284 });
278 } 285 }
279 }.bind(this)); 286 }.bind(this));
280 }.bind(this), 0); 287 }.bind(this), 0);
281 }.bind(this)); 288 }.bind(this));
282 }, 289 },
283 }); 290 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698