Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: chrome/test/data/webui/settings/advanced_page_browsertest.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Simplify, remove unnecessary file. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** @fileoverview Suite of tests for the Settings advanced page. */ 5 /** @fileoverview Suite of tests for the Settings advanced page. */
6 6
7 GEN_INCLUDE(['settings_page_browsertest.js']); 7 GEN_INCLUDE(['settings_page_browsertest.js']);
8 8
9 /** 9 /**
10 * @constructor 10 * @constructor
(...skipping 23 matching lines...) Expand all
34 suite('SettingsPage', function() { 34 suite('SettingsPage', function() {
35 suiteSetup(function() { 35 suiteSetup(function() {
36 self.toggleAdvanced(); 36 self.toggleAdvanced();
37 }); 37 });
38 38
39 test('load page', function() { 39 test('load page', function() {
40 // This will fail if there are any asserts or errors in the Settings page. 40 // This will fail if there are any asserts or errors in the Settings page.
41 }); 41 });
42 42
43 test('advanced pages', function() { 43 test('advanced pages', function() {
44 var page = self.getPage('basic'); 44 var page = self.page;
45 var sections = ['privacy', 'passwordsAndForms', 'languages', 'downloads', 45 var sections = ['privacy', 'passwordsAndForms', 'languages', 'downloads',
46 'reset']; 46 'reset'];
47 if (cr.isChromeOS) 47 if (cr.isChromeOS)
48 sections = sections.concat(['dateTime', 'a11y']); 48 sections = sections.concat(['dateTime', 'a11y']);
49 49
50 for (var i = 0; i < sections.length; i++) { 50 for (var i = 0; i < sections.length; i++) {
51 var section = self.getSection(page, sections[i]); 51 var section = self.getSection(page, sections[i]);
52 expectTrue(!!section); 52 assertTrue(!!section);
dpapad 2017/03/16 20:47:16 FYI, changed this because the expect() made no sen
53 self.verifySubpagesHidden(section); 53 self.verifySubpagesHidden(section);
54 } 54 }
55 }); 55 });
56 }); 56 });
57 57
58 // Run all registered tests. 58 // Run all registered tests.
59 mocha.run(); 59 mocha.run();
60 }); 60 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698