Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 275453002: Update WebFrameClient::didClearWindowObject API (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
dcarney
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Update WebFrameClient::didClearWindowObject API The world_id is now always zero. BUG=none R=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -39 lines) Patch
M content/public/renderer/render_frame_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_view_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/java/java_bridge_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/java/java_bridge_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M content/renderer/web_ui_mojo.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/web_ui_mojo.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/renderer/shell_render_view_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/renderer/shell_render_view_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-07 12:36:59 UTC) #1
dcarney
lgtm
6 years, 7 months ago (2014-05-07 13:51:53 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-09 12:40:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/275453002/1
6 years, 7 months ago (2014-05-09 12:46:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 16:05:29 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 11:59:12 UTC) #6
Message was sent while issue was closed. 
Change committed as 269569

Powered by Google App Engine
This is Rietveld 408576698