Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: ui/android/java/src/org/chromium/ui/base/WindowAndroid.java

Issue 2754493002: Expose VSync pausing through WindowAndroid and pause VSync during webVR presentation (Closed)
Patch Set: remove log Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
diff --git a/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java b/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
index 882bb14deb693a3976aa16587107f750d30b6bf5..f16d20af569bbb2593c2168b11515abc2d9c0738 100644
--- a/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
+++ b/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
@@ -109,6 +109,9 @@ public class WindowAndroid {
private AndroidPermissionDelegate mPermissionDelegate;
+ private boolean mPendingVSyncRequest;
+ private boolean mVSyncPaused;
+
/**
* An interface to notify listeners of changes in the soft keyboard's visibility.
*/
@@ -134,6 +137,10 @@ public class WindowAndroid {
private final VSyncMonitor.Listener mVSyncListener = new VSyncMonitor.Listener() {
@Override
public void onVSync(VSyncMonitor monitor, long vsyncTimeMicros) {
+ if (mVSyncPaused) {
+ mPendingVSyncRequest = true;
+ return;
+ }
if (mNativeWindowAndroid != 0) {
nativeOnVSync(mNativeWindowAndroid,
vsyncTimeMicros,
@@ -497,6 +504,10 @@ public class WindowAndroid {
@CalledByNative
private void requestVSyncUpdate() {
+ if (mVSyncPaused) {
+ mPendingVSyncRequest = true;
+ return;
+ }
mVSyncMonitor.requestUpdate();
}
@@ -557,6 +568,7 @@ public class WindowAndroid {
public long getNativePointer() {
if (mNativeWindowAndroid == 0) {
mNativeWindowAndroid = nativeInit(mDisplayAndroid.getDisplayId());
+ if (mVSyncPaused) nativeSetVSyncPaused(mNativeWindowAndroid, true);
}
return mNativeWindowAndroid;
}
@@ -724,6 +736,17 @@ public class WindowAndroid {
}
}
+ /**
+ * Pauses/Unpauses VSync. When VSync is paused the compositor for this window will idle, and
+ * requestAnimationFrame callbacks won't fire, etc.
+ */
+ public void setVSyncPaused(boolean paused) {
+ if (mVSyncPaused == paused) return;
+ mVSyncPaused = paused;
+ if (!mVSyncPaused && mPendingVSyncRequest) requestVSyncUpdate();
+ if (mNativeWindowAndroid != 0) nativeSetVSyncPaused(mNativeWindowAndroid, paused);
+ }
+
private native long nativeInit(int displayId);
private native void nativeOnVSync(long nativeWindowAndroid,
long vsyncTimeMicros,
@@ -731,6 +754,7 @@ public class WindowAndroid {
private native void nativeOnVisibilityChanged(long nativeWindowAndroid, boolean visible);
private native void nativeOnActivityStopped(long nativeWindowAndroid);
private native void nativeOnActivityStarted(long nativeWindowAndroid);
+ private native void nativeSetVSyncPaused(long nativeWindowAndroid, boolean paused);
private native void nativeDestroy(long nativeWindowAndroid);
}

Powered by Google App Engine
This is Rietveld 408576698