Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 2754483003: Enable TabManager to kill foreground Android apps.

Created:
3 years, 9 months ago by cylee1
Modified:
3 years, 8 months ago
Reviewers:
bccheng1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable TabManager to kill foreground Android apps. In the past TabManager never kill Android apps which are visible to users (whether it's in the foreground or not). It basically only kills Android background processes with no GUI. On machines with limited memory it may be necessary to kill visible Android apps as well so the system can run smoothly. BUG=b:36207466 TEST=samus

Patch Set 1 #

Patch Set 2 : Enable TabManager to kill visible Android apps. #

Patch Set 3 : Enable TabManager to kill visible Android apps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bccheng1
Should we avoid focused_apps but just kill visible_apps?
3 years, 9 months ago (2017-03-15 14:20:40 UTC) #4
semenzato
On 2017/03/15 14:20:40, bccheng1 wrote: > Should we avoid focused_apps but just kill visible_apps? What ...
3 years, 9 months ago (2017-03-16 17:26:33 UTC) #5
semenzato
On 2017/03/16 17:26:33, semenzato wrote: > On 2017/03/15 14:20:40, bccheng1 wrote: > > Should we ...
3 years, 9 months ago (2017-03-16 17:28:30 UTC) #6
teravest
3 years, 8 months ago (2017-04-12 19:33:46 UTC) #7
On 2017/03/16 17:28:30, semenzato wrote:
> On 2017/03/16 17:26:33, semenzato wrote:
> > On 2017/03/15 14:20:40, bccheng1 wrote:
> > > Should we avoid focused_apps but just kill visible_apps?
> > 
> > What if we only have visible apps left?  Shouldn't we also kill those in LRU
> > order?
> > 
> > The alternatives are:
> > 
> > 1. let the kernel OOM killer kill them
> > 2. panic
> 
> I meant "what if we have only focused apps left".
> Actually, in theory there is only ONE focused app, right?
> It may still be better to kill it than let the browser crash or the system
> panic.

Is this change still being considered? Just curious if this is something we'll
try.

Powered by Google App Engine
This is Rietveld 408576698