Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 2754473005: Improve performance of PluginLocator by caching results (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve performance of PluginLocator by caching results R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/550443f14757e607cc9d2848e05ec7d0b6a5b191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/plugin/plugin_locator.dart View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 9 months ago (2017-03-15 21:55:59 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-15 23:11:24 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-16 14:28:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
550443f14757e607cc9d2848e05ec7d0b6a5b191 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698