Issue 2754473004: Replace making getInnermostContext public with making a getFolder method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2754473004: Replace making getInnermostContext public with making a getFolder method (Closed)

Created:
3 years, 9 months ago by mfairhurst

Modified:
3 years, 9 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Replace making getInnermostContext public with making a getFolder method This way SingleContextManager can fulfill the interface too (it can't provide a ContextInfo, and the concept of `innermost` doesn't really exist). BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/985160c08daec21804fec993566b961a5f819ed6

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -17 lines)			Patch
	M	pkg/analysis_server/lib/src/context_manager.dart	View		8 chunks	+20 lines, -17 lines	0 comments	Download
	M	pkg/analysis_server/lib/src/single_context_manager.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

mfairhurst

3 years, 9 months ago (2017-03-14 23:13:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
985160c08daec21804fec993566b961a5f819ed6 (presubmit successful).