Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2754453004: Add note to changelog about support for importing dart:io in dart2js. (Closed)

Created:
3 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 9 months ago
Reviewers:
dgrove, Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add note to changelog about support for importing dart:io in dart2js. R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/0549e8caefa4be4f0efa773cf4ac6c7ba6842458

Patch Set 1 #

Patch Set 2 : include dartium too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M CHANGELOG.md View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Siggi Cherem (dart-lang)
3 years, 9 months ago (2017-03-15 23:36:44 UTC) #2
Jacob
lgtm
3 years, 9 months ago (2017-03-15 23:46:49 UTC) #3
Siggi Cherem (dart-lang)
thanks, added dartium as well.
3 years, 9 months ago (2017-03-15 23:53:25 UTC) #4
Siggi Cherem (dart-lang)
Committed patchset #2 (id:20001) manually as 0549e8caefa4be4f0efa773cf4ac6c7ba6842458 (presubmit successful).
3 years, 9 months ago (2017-03-15 23:54:20 UTC) #6
Jacob
3 years, 9 months ago (2017-03-16 00:15:32 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698