Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_const_expr.dart

Issue 2754423002: Fail inference when an instance field is referenced. (Closed)
Patch Set: Clean up and move tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/link.dart ('k') | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/summarize_const_expr.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
index dcde920733b39fa7586c3118341441b29325bca8..def774ad9858df6a56aa379d34b20335f9587f7d 100644
--- a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
@@ -369,7 +369,8 @@ abstract class AbstractConstExprSerializer {
} else if (expr is AssignmentExpression) {
_serializeAssignment(expr);
} else if (expr is CascadeExpression) {
- _serializeCascadeExpression(expr);
+ isValidConst = false;
+ _serialize(expr.target);
} else if (expr is FunctionExpression) {
isValidConst = false;
List<int> indices = serializeFunctionExpression(expr);
@@ -519,15 +520,6 @@ abstract class AbstractConstExprSerializer {
}
}
- void _serializeCascadeExpression(CascadeExpression expr) {
- _serialize(expr.target);
- for (Expression section in expr.cascadeSections) {
- operations.add(UnlinkedExprOperation.cascadeSectionBegin);
- _serialize(section);
- operations.add(UnlinkedExprOperation.cascadeSectionEnd);
- }
- }
-
void _serializeListLiteral(ListLiteral expr) {
List<Expression> elements = expr.elements;
elements.forEach(_serialize);
« no previous file with comments | « pkg/analyzer/lib/src/summary/link.dart ('k') | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698