Fail inference when an instance field is referenced.

pkg/analyzer/test/src/summary/linker_test.dart

Index: pkg/analyzer/test/src/summary/linker_test.dart
diff --git a/pkg/analyzer/test/src/summary/linker_test.dart b/pkg/analyzer/test/src/summary/linker_test.dart
index cd70c5dac03aaaf0a7a4a2f8de82a2d6ce799972..148b9affa2688a7552b18a664b739ea2289c2eb5 100644
--- a/pkg/analyzer/test/src/summary/linker_test.dart
+++ b/pkg/analyzer/test/src/summary/linker_test.dart
@@ -348,7 +348,7 @@ var y = C.x;
 ''');
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
     expect(_getVariable(library.getContainedName('y')).inferredType.toString(),
-        '(D) → E');
+        '(D) → dynamic');

[Brian Wilkerson, 2017/03/17 22:39:42]

Are these tests worth keeping? If we're not doing any inference then we're only
checking for standard resolution, which we have presumably tested elsewhere.

[scheglov, 2017/03/18 01:54:52]

It is partially a question of taste.
Tests in this file (linker_test.dart) are closer to unit tests.
Parsing, summarizing and linking is finely grained orchestrated by the test
itself, there is special test specific machinery for this.

Tests in the other file (top_level_inference_test.dart) are shifted closer to
functional tests.
We use AnalysisDriver to parse files, create unlinked summaries, linking and
resynthesizing.
No additional machinery in the test itself, but more happens under hood.

I incline to review these tests and move them to top_level_inference_test at
some point.



As for other tests that I touched in this CL in general, that's a fair question.
Many of them test features that are now not allowed. Unfortunately most of these
tests are bulky and test many things at once. So, careful surgery is required to
severe parts that we still want to test from the parts that are not necessary
anymore. I plan to review these tests and make these changes before landing this
CL.

   }
 
   void test_inferredType_instanceField_conditional_genericFunctions() {
@@ -489,11 +489,11 @@ class C {
     addBundle('/a.ds', bundle);
     createLinker('''
 import 'a.dart';
-var x = new C().f; // Inferred type: int
+var x = new C().f; // Inferred type: dynamic
 ''');
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
     expect(_getVariable(library.getContainedName('x')).inferredType.toString(),
-        'int');
+        'dynamic');
   }
 
   void test_inferredTypeFromOutsideBuildUnit_instanceField_toInstanceField() {
@@ -513,7 +513,7 @@ class D {
 ''');
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
     ClassElementForLink_Class classD = library.getContainedName('D');
-    expect(classD.fields[0].inferredType.toString(), 'int');
+    expect(classD.fields[0].inferredType.toString(), 'dynamic');
   }
 
   void test_inferredTypeFromOutsideBuildUnit_methodParamType_viaGeneric() {