Fail inference when an instance field is referenced.

pkg/analyzer/lib/src/task/dart.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.dart;
 
 import 'dart:collection';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
@@ skipping 3444 matching lines @@
   @override
   TaskDescriptor get descriptor => DESCRIPTOR;
 
   @override
   void internalPerform() {
     //
     // Prepare inputs.
     //
     CompilationUnit unit = getRequiredInput(UNIT_INPUT);
     TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT);
+
+    //
+    // Prepare fields for which inference should be disabled.
+    //
+    Set<FieldElement> fieldsWithDisabledInference = new Set<FieldElement>();
+    for (CompilationUnitMember classDeclaration in unit.declarations) {
+      if (classDeclaration is ClassDeclaration) {
+        for (ClassMember fieldDeclaration in classDeclaration.members) {
+          if (fieldDeclaration is FieldDeclaration) {
+            if (!fieldDeclaration.isStatic) {
+              for (VariableDeclaration field
+                  in fieldDeclaration.fields.variables) {
+                Expression initializer = field.initializer;
+                if (initializer != null &&
+                    !isValidForTypeInference(initializer)) {
+                  fieldsWithDisabledInference.add(field.element);
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+
     //
     // Infer instance members.
     //
     if (context.analysisOptions.strongMode) {
       InstanceMemberInferrer inferrer = new InstanceMemberInferrer(
           typeProvider,
           new InheritanceManager(
               resolutionMap.elementDeclaredByCompilationUnit(unit).library),
+          fieldsWithDisabledInference,
           typeSystem: context.typeSystem);
       inferrer.inferCompilationUnit(unit.element);
     }
     //
     // Record outputs.
     //
     outputs[RESOLVED_UNIT10] = unit;
     outputs[CREATED_RESOLVED_UNIT10] = true;
   }
 
@@ skipping 252 matching lines @@
       ResolverVisitor visitor = new ResolverVisitor(
           variable.library, variable.source, typeProvider, errorListener,
           nameScope: resolutionContext.scope);
       if (resolutionContext.enclosingClassDeclaration != null) {
         visitor.prepareToResolveMembersInClass(
             resolutionContext.enclosingClassDeclaration);
       }
       visitor.initForIncrementalResolution();
       initializer.accept(visitor);
 
+      DartType newType;
+      if (!isValidForTypeInference(initializer)) {
+        newType = typeProvider.dynamicType;
+      } else {
+        newType = initializer.staticType;
+        if (newType == null || newType.isBottom || newType.isDartCoreNull) {
+          newType = typeProvider.dynamicType;
+        }
+      }
+
       //
       // Record the type of the variable.
       //
-      DartType newType = initializer.staticType;
-      if (newType == null || newType.isBottom || newType.isDartCoreNull) {
-        newType = typeProvider.dynamicType;
-      }
       setFieldType(variable, newType);
       errors = getUniqueErrors(errorListener.errors);
     } else {
       // TODO(brianwilkerson) For now we simply don't infer any type for
       // variables or fields involved in a cycle. We could try to be smarter
       // by re-resolving the initializer in a context in which the types of all
       // of the variables in the cycle are assumed to be `null`, but it isn't
       // clear to me that this would produce better results often enough to
       // warrant the extra effort.
     }
@@ skipping 2794 matching lines @@
 
   @override
   bool moveNext() {
     if (_newSources.isEmpty) {
       return false;
     }
     currentTarget = _newSources.removeLast();
     return true;
   }
 }