Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 27544002: Have Document::fonts() return a raw pointer (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
Reviewers:
adamk
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Have Document::fonts() return a raw pointer Have Document::fonts() return a raw pointer instead of a PassRefPtr as we are not passing ownership to the caller. R=adamk BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/core/dom/Document.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
7 years, 2 months ago (2013-10-16 17:33:02 UTC) #1
adamk
lgtm This makes me think we might want to consider adding bindings code that knows ...
7 years, 2 months ago (2013-10-16 18:15:41 UTC) #2
Inactive
On 2013/10/16 18:15:41, adamk wrote: > lgtm > > This makes me think we might ...
7 years, 2 months ago (2013-10-16 18:26:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27544002/1
7 years, 2 months ago (2013-10-16 18:27:25 UTC) #4
adamk
On 2013/10/16 18:26:49, Chris Dumez wrote: > On 2013/10/16 18:15:41, adamk wrote: > > lgtm ...
7 years, 2 months ago (2013-10-16 18:40:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27544002/1
7 years, 2 months ago (2013-10-16 20:43:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27544002/1
7 years, 2 months ago (2013-10-17 01:37:51 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-17 09:00:14 UTC) #8
Message was sent while issue was closed.
Change committed as 159846

Powered by Google App Engine
This is Rietveld 408576698